Skip to content

Conversation

@sanderegg
Copy link
Member

What do these changes do?

This PR makes some E2E tests more robusts.

  • waiting time on S4l in internal deployments was set to 1 minute, and waiting on the websocket messages as well. this does not go well. outer timeout is now set to 2 minutes.
  • same for tip

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Pirulo milestone May 5, 2025
@sanderegg sanderegg self-assigned this May 5, 2025
@sanderegg sanderegg added t:maintenance Some planned maintenance work e2e Bugs found by or related to the end-2-end testing labels May 5, 2025
@sanderegg sanderegg marked this pull request as ready for review May 5, 2025 15:15
@sanderegg sanderegg requested a review from GitHK May 5, 2025 15:15
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 5, 2025

@codecov
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.50%. Comparing base (fc054d6) to head (32d4f93).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7633      +/-   ##
==========================================
- Coverage   87.72%   87.50%   -0.23%     
==========================================
  Files        1788     1744      -44     
  Lines       68979    66646    -2333     
  Branches     1134     1134              
==========================================
- Hits        60515    58316    -2199     
+ Misses       8153     8018     -135     
- Partials      311      312       +1     
Flag Coverage Δ
integrationtests 65.03% <ø> (+0.07%) ⬆️
unittests 86.66% <ø> (-0.28%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.92% <ø> (ø)
pkg_dask_task_models_library 97.38% <ø> (ø)
pkg_models_library 92.80% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.41% <ø> (ø)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library 73.02% <ø> (-0.06%) ⬇️
pkg_settings_library 90.90% <ø> (ø)
pkg_simcore_sdk 85.66% <ø> (+0.17%) ⬆️
agent 96.46% <ø> (ø)
api_server 92.50% <ø> (ø)
autoscaling ∅ <ø> (∅)
catalog 92.64% <ø> (ø)
clusters_keeper 99.25% <ø> (ø)
dask_sidecar 91.37% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.80% <ø> (-0.10%) ⬇️
director_v2 91.22% <ø> (+0.09%) ⬆️
dynamic_scheduler 96.76% <ø> (ø)
dynamic_sidecar 90.15% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.12% <ø> (-0.06%) ⬇️
storage 87.56% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 86.02% <ø> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc054d6...32d4f93. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg merged commit 9a0e28a into ITISFoundation:master May 5, 2025
91 of 95 checks passed
@sanderegg sanderegg deleted the e2e/wait-on-project-open branch May 5, 2025 16:02
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e Bugs found by or related to the end-2-end testing t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants