Skip to content

Conversation

@sanderegg
Copy link
Member

What do these changes do?

This PR definitely removes aiopg dependency from dv-2, even from tests requirements.
Also adds a warning in the aiopg_engine fixture in pytest-simcore.

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Bazinga! milestone May 6, 2025
@sanderegg sanderegg self-assigned this May 6, 2025
@sanderegg sanderegg added the a:director-v2 issue related with the director-v2 service label May 6, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2025

@codecov
Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.76%. Comparing base (fc62ac0) to head (3f2878a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7638      +/-   ##
==========================================
+ Coverage   87.72%   87.76%   +0.03%     
==========================================
  Files        1788     1781       -7     
  Lines       68979    68789     -190     
  Branches     1134     1134              
==========================================
- Hits        60515    60374     -141     
+ Misses       8152     8103      -49     
  Partials      312      312              
Flag Coverage Δ
integrationtests 64.99% <ø> (+0.07%) ⬆️
unittests 86.96% <ø> (+0.03%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.92% <ø> (ø)
pkg_dask_task_models_library 97.38% <ø> (ø)
pkg_models_library 92.80% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.41% <ø> (ø)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library 73.02% <ø> (ø)
pkg_settings_library 90.90% <ø> (ø)
pkg_simcore_sdk 85.72% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 92.50% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.64% <ø> (ø)
clusters_keeper 99.25% <ø> (ø)
dask_sidecar 91.37% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.80% <ø> (ø)
director_v2 91.12% <ø> (+0.01%) ⬆️
dynamic_scheduler 96.76% <ø> (ø)
dynamic_sidecar 90.15% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.23% <ø> (ø)
storage 87.56% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 86.04% <ø> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc62ac0...3f2878a. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sanderegg sanderegg merged commit a2e009f into ITISFoundation:master May 6, 2025
95 checks passed
@sanderegg sanderegg deleted the director-v2/completely-remove-aiopg branch May 6, 2025 07:11
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:director-v2 issue related with the director-v2 service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants