- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
          🎨 add WAITING_FOR_RESOURCES to get_pipeline_state_from_task_states
          #7640
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
  
    🎨 add WAITING_FOR_RESOURCES to get_pipeline_state_from_task_states
  
  #7640
              Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: why is this required?
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 
 Additional details and impacted files@@             Coverage Diff             @@
##           master    #7640       +/-   ##
===========================================
- Coverage   87.75%   69.91%   -17.84%     
===========================================
  Files        1788      692     -1096     
  Lines       68979    32523    -36456     
  Branches     1134      170      -964     
===========================================
- Hits        60530    22740    -37790     
- Misses       8138     9725     +1587     
+ Partials      311       58      -253     
 
 Continue to review full report in Codecov by Sentry. 
 🚀 New features to boost your workflow:
  | 
    
          
 because it is missing. if task is in state   | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add your comment to the description of the PR, the reason for the change was not clear to me
        
          
                services/director-v2/src/simcore_service_director_v2/utils/computations.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pair reviewed
          
 | 
    
1168c77
      into
      
  
    ITISFoundation:master
  
    


What do these changes do?
WAITING_FOR_RESOURCEStoget_pipeline_state_from_task_states--> fixing: if task was in state WAITING_FOR_RESOURCES it was reported as ERROR in the Comp runsRelated issue/s
How to test
Dev-ops