- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
♻️Dask sidecar: Glob error tests + autoscaling monitoring fix #7650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️Dask sidecar: Glob error tests + autoscaling monitoring fix #7650
Conversation
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@            Coverage Diff             @@
##           master    #7650      +/-   ##
==========================================
+ Coverage   87.72%   87.74%   +0.02%     
==========================================
  Files        1791     1784       -7     
  Lines       69088    68898     -190     
  Branches     1134     1134              
==========================================
- Hits        60609    60457     -152     
+ Misses       8168     8130      -38     
  Partials      311      311              
 
 Continue to review full report in Codecov by Sentry. 
 🚀 New features to boost your workflow:
  | 
    
| 
           @sanderegg what are the implications? Will I get less information about comp. clusters in summary?  | 
    
          
 yes. no information about dask related data such as # jobs, dask resources, etc. but you would still see the machines.  | 
    
          
 jq -r ".computational_clusters[].primary.user_id" summary.json
jq -r ".dynamic_instances[].ec2_instance_id"  summary.jsonDoes CLI still preserve fields mentioned above? @sanderegg  | 
    
          
 yep @YuryHrytsuk  | 
    
596d647    to
    45390aa      
    Compare
  
    
          
 | 
    



What do these changes do?
Refactored tests, tested against AWS when the glob error appears in fsspec.
This is actually the standard error when a file is not found.
if the file expired it is actually also the same.
Bonus:
Related issue/s
How to test
Dev-ops