✨ [Frontend] Create Functions #7653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
requested review from
GitHK,
bisgaard-itis,
Copilot,
giancarloromeo,
matusdrobuliak66,
sanderegg and
wvangeit
There was a problem hiding this comment.
Pull Request Overview
This PR introduces the first iteration for creating functions in the study pipeline. Key changes include:
- New utility functions in Utils.js for extracting file-pickers, parameters, and probes, and a new boolean check (canCreateFunction) for when a function can be created.
- A new CreateFunction widget in CreateFunction.js that builds a form for naming and configuring functions based on study data.
- Updates to related files (Resources.js, ResourceDetails.js, ParameterEditor.js, and service Utils.js) to support and integrate this new functionality.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| osparc/study/Utils.js | Added helper functions (extractFilePickers, extractParameters, extractProbes) and canCreateFunction logic. |
| osparc/study/CreateFunction.js | Introduced new widget for function creation with form layout and API interactions. |
| osparc/service/Utils.js | Added utility functions to extract parameter and probe types/values. |
| osparc/node/ParameterEditor.js | Updated to use the new parameter type extraction. |
| osparc/data/Resources.js | Added configuration for the "functions" endpoint. |
| osparc/dashboard/ResourceDetails.js | Integrated the new Create Function page and updated related UI elements. |
services/static-webserver/client/source/class/osparc/study/Utils.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/study/CreateFunction.js
Show resolved
Hide resolved
wvangeit
reviewed
May 12, 2025
services/static-webserver/client/source/class/osparc/study/CreateFunction.js
Show resolved
Hide resolved
JavierGOrdonnez
approved these changes
May 12, 2025
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 5125753 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR is the first iteration on the Creation of Functions required by the Meta Modeling case.
In order to be able to create a function out of a study, the study pipeline needs:
if these requirements are met, a Create Function section will appear in the Study Card. From here, one can give a name, description and decide which inputs and outputs will be exposed.
When Create Function is pressed, the frontend will request the backend to create a template from the study, and then it will call "POST" the
/functionsendpoint (coming here).Related issue/s
How to test
Dev-ops