- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
🎨 Improve web-api listing task manager (download logs, credits, node name) #7656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Improve web-api listing task manager (download logs, credits, node name) #7656
Conversation
          Codecov ReportAttention: Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##           master    #7656      +/-   ##
==========================================
+ Coverage   87.44%   87.58%   +0.13%     
==========================================
  Files        1754     1615     -139     
  Lines       66943    65105    -1838     
  Branches     1134      892     -242     
==========================================
- Hits        58538    57019    -1519     
+ Misses       8094     7841     -253     
+ Partials      311      245      -66     
 
 Continue to review full report in Codecov by Sentry. 
 🚀 New features to boost your workflow:
  | 
    
        
          
                services/director-v2/src/simcore_service_director_v2/api/rpc/_computations.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                services/web/server/src/simcore_service_webserver/director_v2/_computations_service.py
          
            Show resolved
            Hide resolved
        
      There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check the few comments. not sure I get the purpose of some of the models. thanks!
        
          
                packages/models-library/src/models_library/api_schemas_directorv2/comp_runs.py
          
            Show resolved
            Hide resolved
        
              
          
                services/director-v2/src/simcore_service_director_v2/api/rpc/_computations.py
              
                Outdated
          
            Show resolved
            Hide resolved
        
              
          
                services/director-v2/src/simcore_service_director_v2/models/comp_tasks.py
          
            Show resolved
            Hide resolved
        
      
          
 | 
    
| 
           Thanks 👍  | 
    



What do these changes do?
NEXT PR will finish with:
Related issue/s
How to test
Dev-ops