Skip to content

🎨 Improve web-api listing task manager (download logs, credits, node name) #7656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 12, 2025
Merged

🎨 Improve web-api listing task manager (download logs, credits, node name) #7656

merged 15 commits into from
May 12, 2025

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented May 12, 2025 •
edited
Loading

What do these changes do?

  • 🎨 Improve web-api listing task manager (download logs, credits, node name)

NEXT PR will finish with:

Related issue/s

How to test

Dev-ops

@matusdrobuliak66 matusdrobuliak66 self-assigned this May 12, 2025
@matusdrobuliak66 matusdrobuliak66 added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:director-v2 issue related with the director-v2 service a:resource-usage-tracker resource usage tracker service labels May 12, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Bazinga! milestone May 12, 2025
@codecov
Copy link

codecov bot commented May 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 81.88976% with 23 lines in your changes missing coverage. Please review.

Project coverage is 87.58%. Comparing base (c131aca) to head (b032154).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7656      +/-   ##
==========================================
+ Coverage   87.44%   87.58%   +0.13%     
==========================================
  Files        1754     1615     -139     
  Lines       66943    65105    -1838     
  Branches     1134      892     -242     
==========================================
- Hits        58538    57019    -1519     
+ Misses       8094     7841     -253     
+ Partials      311      245      -66
Flag Coverage Δ
integrationtests 64.91% <42.25%> (-0.05%) ⬇️
unittests 86.75% <81.88%> (+0.11%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 92.86% <100.00%> (+0.06%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library 72.95% <0.00%> (-0.08%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.48% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 92.50% <ø> (ø)
autoscaling 96.08% <ø> (∅)
catalog 92.64% <ø> (ø)
clusters_keeper 99.25% <ø> (ø)
dask_sidecar 89.88% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.89% <ø> (ø)
director_v2 91.10% <87.17%> (+<0.01%) ⬆️
dynamic_scheduler 96.76% <ø> (ø)
dynamic_sidecar 90.15% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.63% <ø> (ø)
resource_usage_tracker 89.13% <78.94%> (-0.11%) ⬇️
storage 87.49% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 86.02% <87.50%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c131aca...b032154. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review May 12, 2025 08:16
GitHK
GitHK approved these changes May 12, 2025
View reviewed changes
sanderegg
sanderegg approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check the few comments. not sure I get the purpose of some of the models. thanks!

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) May 12, 2025 13:45
@matusdrobuliak66 matusdrobuliak66 added the 🤖-automerge marks PR as ready to be merged for Mergify label May 12, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 12, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sanderegg sanderegg disabled auto-merge May 12, 2025 15:11
@sanderegg sanderegg merged commit c888fcc into ITISFoundation:master May 12, 2025
94 of 95 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the improve-listing-task-manager-2 branch May 12, 2025 15:48
@odeimaiz
Copy link
Member

odeimaiz commented May 12, 2025

Thanks 👍

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 13, 2025
Closed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
Closed
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GitHK GitHK GitHK approved these changes

@sanderegg sanderegg sanderegg approved these changes

@pcrespov pcrespov Awaiting requested review from pcrespov pcrespov is a code owner

@giancarloromeo giancarloromeo Awaiting requested review from giancarloromeo giancarloromeo is a code owner

@odeimaiz odeimaiz Awaiting requested review from odeimaiz

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:director-v2 issue related with the director-v2 service a:resource-usage-tracker resource usage tracker service a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Bazinga!

Development

Successfully merging this pull request may close these issues.

Improve listing: Add credits to the tasks Improve listing: Add download logs link to the task manager

4 participants

@matusdrobuliak66 @odeimaiz @GitHK @sanderegg