Skip to content

Conversation

@bisgaard-itis
Copy link
Contributor

What do these changes do?

  • Call long running tasks module in service_lib directly when listing legacy tasks instead of calling the REST interface.

Related issue/s

How to test

Dev-ops

@bisgaard-itis bisgaard-itis self-assigned this May 12, 2025
@bisgaard-itis bisgaard-itis added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label May 12, 2025
@bisgaard-itis bisgaard-itis added this to the Bazinga! milestone May 12, 2025
@sanderegg sanderegg requested a review from mrnicegyu11 May 12, 2025 08:32
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) May 12, 2025 08:33
@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.49%. Comparing base (5125753) to head (da17b1e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7657      +/-   ##
==========================================
- Coverage   87.72%   87.49%   -0.24%     
==========================================
  Files        1791     1412     -379     
  Lines       69088    58353   -10735     
  Branches     1134      595     -539     
==========================================
- Hits        60608    51055    -9553     
+ Misses       8170     7114    -1056     
+ Partials      310      184     -126     
Flag Coverage Δ
integrationtests 64.92% <57.14%> (-0.02%) ⬇️
unittests 86.56% <100.00%> (-0.38%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 73.02% <100.00%> (ø)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.66% <ø> (+0.05%) ⬆️
agent 96.46% <ø> (ø)
api_server 92.50% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.64% <ø> (ø)
clusters_keeper 99.25% <ø> (ø)
dask_sidecar 89.88% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.89% <ø> (+0.09%) ⬆️
director_v2 91.10% <ø> (-0.05%) ⬇️
dynamic_scheduler 96.76% <ø> (ø)
dynamic_sidecar 90.15% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.63% <ø> (ø)
resource_usage_tracker 89.12% <ø> (ø)
storage 87.49% <ø> (-0.11%) ⬇️
webclient ∅ <ø> (∅)
webserver 86.11% <100.00%> (+0.07%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5125753...da17b1e. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@sanderegg sanderegg disabled auto-merge May 12, 2025 14:27
@sanderegg sanderegg merged commit c131aca into ITISFoundation:master May 12, 2025
94 of 95 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GET /v0/tasks redirect to /v0/tasks-legacy

3 participants