- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
✨ [Frontend] App Browser with Hypertools #7658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [Frontend] App Browser with Hypertools #7658
Conversation
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@            Coverage Diff             @@
##           master    #7658      +/-   ##
==========================================
- Coverage   87.71%   83.74%   -3.97%     
==========================================
  Files        1792     1689     -103     
  Lines       69182    64184    -4998     
  Branches     1136     1136              
==========================================
- Hits        60680    53753    -6927     
- Misses       8192    10121    +1929     
  Partials      310      310              
 *This pull request uses carry forward flags. Click here to find out more. 
 Continue to review full report in Codecov by Sentry. 
 🚀 New features to boost your workflow:
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR renames the Service Browser to App Browser and updates related logic so that services and hypertools are now correctly handled in the app browser. Key changes include:
- Adding “hypertool” as a valid resource type in multiple modules (e.g. Collaborators, ResourceDetails, CardBase).
 - Updating aliases, event names, filtering logic, and UI labels to reflect the new “App Browser” concept.
 - Renaming and refactoring various UI components and utility functions to ensure consistency throughout the dashboard.
 
Reviewed Changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated no comments.
| File | Description | 
|---|---|
| Collaborators.js, Utils.js, Product/Utils.js | Integrated “hypertool” as a resource type alongside study/template and updated alias helpers. | 
| SearchBarFilter.js, ResourceFilter.js | Renamed filter components from service to app type and updated event names accordingly. | 
| Dashboard.js, CardBase.js, ListButtonItem.js, GridButtonItem.js | Revised resource type checks and UI labels to include “hypertool” for consistent display. | 
| AppBrowser.js | Reworked the browser logic to load both services and hypertools, renamed methods, and updated UI actions. | 
Comments suppressed due to low confidence (2)
services/static-webserver/client/source/class/osparc/dashboard/AppBrowser.js:100
- [nitpick] Consider renaming the parameter 'serviceData' to 'appData' (and updating related variable names) for clarity since this browser now handles apps in addition to hypertools.
 
_updateServiceData: function(serviceData) {
services/static-webserver/client/source/class/osparc/dashboard/AppBrowser.js:100
- [nitpick] Since the browser is renamed to AppBrowser and is intended to list both services and hypertools, consider mapping the resource type 'service' to 'app' consistently across the module to support coherent aliasing and filtering.
 
serviceData["resourceType"] = "service";
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for updating the e2e
…eimaiz/osparc-simcore into feature/hypertools-in-service-browser
| 
           Please retry analysis of this Pull-Request directly on SonarQube Cloud  | 
    
What do these changes do?
Bonus:
isDevFeaturesEnabledflagRelated issue/s
How to test
Dev-ops