Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented May 12, 2025

What do these changes do?

  • Rename Service Browser to App Browser
  • In the App browser Services and Hypertools are listed (at the end of the list)
  • There is a Hypertool filter to the left column

Bonus:

  • Display "Public" instead of the {{product_name}} on tooltips and sharing items
  • The features that go in release v9 do not depend on the isDevFeaturesEnabled flag
  • Some work on the Activity Center

HypertoolsInApps

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz added this to the Bazinga! milestone May 12, 2025
@odeimaiz odeimaiz self-assigned this May 12, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels May 12, 2025
@codecov
Copy link

codecov bot commented May 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.74%. Comparing base (891ceac) to head (1037fdd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7658      +/-   ##
==========================================
- Coverage   87.71%   83.74%   -3.97%     
==========================================
  Files        1792     1689     -103     
  Lines       69182    64184    -4998     
  Branches     1136     1136              
==========================================
- Hits        60680    53753    -6927     
- Misses       8192    10121    +1929     
  Partials      310      310              
Flag Coverage Δ *Carryforward flag
integrationtests 64.88% <ø> (-0.06%) ⬇️
unittests 82.75% <ø> (-4.18%) ⬇️ Carriedforward from 891ceac

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 93.92% <ø> (ø)
pkg_dask_task_models_library 98.48% <ø> (ø)
pkg_models_library 92.86% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.41% <ø> (ø)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library 72.95% <ø> (ø)
pkg_settings_library 90.90% <ø> (ø)
pkg_simcore_sdk 85.48% <ø> (-0.06%) ⬇️
agent 96.46% <ø> (ø)
api_server 92.50% <ø> (ø)
autoscaling ∅ <ø> (∅)
catalog 92.64% <ø> (ø)
clusters_keeper 99.25% <ø> (ø)
dask_sidecar 89.88% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.80% <ø> (ø)
director_v2 91.14% <ø> (ø)
dynamic_scheduler 96.76% <ø> (ø)
dynamic_sidecar 90.15% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.63% <ø> (ø)
resource_usage_tracker 89.02% <ø> (ø)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 74.55% <ø> (-11.48%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 891ceac...1037fdd. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@odeimaiz odeimaiz marked this pull request as ready for review May 13, 2025 09:22
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the Service Browser to App Browser and updates related logic so that services and hypertools are now correctly handled in the app browser. Key changes include:

  • Adding “hypertool” as a valid resource type in multiple modules (e.g. Collaborators, ResourceDetails, CardBase).
  • Updating aliases, event names, filtering logic, and UI labels to reflect the new “App Browser” concept.
  • Renaming and refactoring various UI components and utility functions to ensure consistency throughout the dashboard.

Reviewed Changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated no comments.

File Description
Collaborators.js, Utils.js, Product/Utils.js Integrated “hypertool” as a resource type alongside study/template and updated alias helpers.
SearchBarFilter.js, ResourceFilter.js Renamed filter components from service to app type and updated event names accordingly.
Dashboard.js, CardBase.js, ListButtonItem.js, GridButtonItem.js Revised resource type checks and UI labels to include “hypertool” for consistent display.
AppBrowser.js Reworked the browser logic to load both services and hypertools, renamed methods, and updated UI actions.
Comments suppressed due to low confidence (2)

services/static-webserver/client/source/class/osparc/dashboard/AppBrowser.js:100

  • [nitpick] Consider renaming the parameter 'serviceData' to 'appData' (and updating related variable names) for clarity since this browser now handles apps in addition to hypertools.
_updateServiceData: function(serviceData) {

services/static-webserver/client/source/class/osparc/dashboard/AppBrowser.js:100

  • [nitpick] Since the browser is renamed to AppBrowser and is intended to list both services and hypertools, consider mapping the resource type 'service' to 'app' consistently across the module to support coherent aliasing and filtering.
serviceData["resourceType"] = "service";

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for updating the e2e

@sonarqubecloud
Copy link

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@odeimaiz odeimaiz merged commit c49b779 into ITISFoundation:master May 13, 2025
94 of 95 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants