✨ [Frontend] App Browser with Hypertools #7658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7658 +/- ##
==========================================
- Coverage 87.71% 83.74% -3.97%
==========================================
Files 1792 1689 -103
Lines 69182 64184 -4998
Branches 1136 1136
==========================================
- Hits 60680 53753 -6927
- Misses 8192 10121 +1929
Partials 310 310
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
odeimaiz
requested review from
GitHK,
Copilot,
giancarloromeo,
pcrespov and
sanderegg
There was a problem hiding this comment.
Pull Request Overview
This PR renames the Service Browser to App Browser and updates related logic so that services and hypertools are now correctly handled in the app browser. Key changes include:
- Adding “hypertool” as a valid resource type in multiple modules (e.g. Collaborators, ResourceDetails, CardBase).
- Updating aliases, event names, filtering logic, and UI labels to reflect the new “App Browser” concept.
- Renaming and refactoring various UI components and utility functions to ensure consistency throughout the dashboard.
Reviewed Changes
Copilot reviewed 37 out of 37 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Collaborators.js, Utils.js, Product/Utils.js | Integrated “hypertool” as a resource type alongside study/template and updated alias helpers. |
| SearchBarFilter.js, ResourceFilter.js | Renamed filter components from service to app type and updated event names accordingly. |
| Dashboard.js, CardBase.js, ListButtonItem.js, GridButtonItem.js | Revised resource type checks and UI labels to include “hypertool” for consistent display. |
| AppBrowser.js | Reworked the browser logic to load both services and hypertools, renamed methods, and updated UI actions. |
Comments suppressed due to low confidence (2)
services/static-webserver/client/source/class/osparc/dashboard/AppBrowser.js:100
- [nitpick] Consider renaming the parameter 'serviceData' to 'appData' (and updating related variable names) for clarity since this browser now handles apps in addition to hypertools.
_updateServiceData: function(serviceData) {
services/static-webserver/client/source/class/osparc/dashboard/AppBrowser.js:100
- [nitpick] Since the browser is renamed to AppBrowser and is intended to list both services and hypertools, consider mapping the resource type 'service' to 'app' consistently across the module to support coherent aliasing and filtering.
serviceData["resourceType"] = "service";
giancarloromeo
approved these changes
May 13, 2025
sanderegg
approved these changes
May 13, 2025
…eimaiz/osparc-simcore into feature/hypertools-in-service-browser
|
Please retry analysis of this Pull-Request directly on SonarQube Cloud |
matusdrobuliak66
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Bonus:
isDevFeaturesEnabledflagRelated issue/s
How to test
Dev-ops