Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented May 13, 2025

What do these changes do?

After testing it looks like the uvloop-powered aiohttp gunicorn worker performs much better than the standard one.
note that the response time on this example project is notably improved.
image

uvloop is a drop-in replacement for the standard asyncio event loop (note that fastapi already uses it by default)

Related issue/s

How to test

Dev-ops

@sanderegg sanderegg added this to the Bazinga! milestone May 13, 2025
@sanderegg sanderegg self-assigned this May 13, 2025
@sanderegg sanderegg added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs t:maintenance Some planned maintenance work labels May 13, 2025
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.44%. Comparing base (36ea2e1) to head (67c7201).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7663      +/-   ##
==========================================
- Coverage   87.71%   86.44%   -1.27%     
==========================================
  Files        1792      530    -1262     
  Lines       69182    23784   -45398     
  Branches     1136        0    -1136     
==========================================
- Hits        60685    20561   -40124     
+ Misses       8187     3223    -4964     
+ Partials      310        0     -310     
Flag Coverage Δ
integrationtests 59.98% <ø> (-4.92%) ⬇️
unittests 87.43% <ø> (+0.50%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk ∅ <ø> (∅)
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 ∅ <ø> (∅)
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 89.17% <ø> (-0.99%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 86.03% <ø> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36ea2e1...67c7201. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sanderegg sanderegg marked this pull request as ready for review May 13, 2025 09:51
Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thanks 👍

@sanderegg sanderegg merged commit 891ceac into ITISFoundation:master May 13, 2025
94 checks passed
@sanderegg sanderegg deleted the webserver/use-uvloop branch May 13, 2025 10:24
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants