- 
                Notifications
    
You must be signed in to change notification settings  - Fork 32
 
✨ [Frontend] Activity Center and Activity Overview #7664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces the new Activity Overview view on the project card and updates the Activity Center to display only active runs, alongside several UI and API updates across job- and study-related components.
- Updated icon paths in LoggerModel and several table files.
 - Refactored Jobs store methods to use active jobs with corresponding renames.
 - Added a new ActivityOverview component and integrated it into resource details, and updated StudyEditor pipeline start/stop flows.
 
Reviewed Changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description | 
|---|---|
| services/static-webserver/client/source/class/osparc/widget/logger/LoggerModel.js | Updated icon paths to the new locations. | 
| services/static-webserver/client/source/class/osparc/store/Jobs.js | Switched to using active jobs fetch and renamed job addition method. | 
| services/static-webserver/client/source/class/osparc/jobs/SubRunsTableModel.js | Changed job state display to use status labels. | 
| services/static-webserver/client/source/class/osparc/jobs/SubRunsTable.js | Updated icon paths, adjusted column widths, and added a selection reset before log actions. | 
| services/static-webserver/client/source/class/osparc/jobs/RunsTableModel.js | Updated job state display and active job fetch usage. | 
| services/static-webserver/client/source/class/osparc/jobs/RunsTable.js | Modified cancel action logic and updated button configurations. | 
| services/static-webserver/client/source/class/osparc/jobs/JobsButton.js | Adjusted active job count handling and event listeners. | 
| services/static-webserver/client/source/class/osparc/jobs/ActivityOverview.js | New component for displaying activity overview. | 
| services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js | Refactored pipeline start/stop functions to use new endpoints and logic. | 
| services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js | Integrated Activity Overview page into the resource details view. | 
| services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserBase.js | Added null checks for the resources container when managing task cards. | 
| services/static-webserver/client/source/class/osparc/data/SubJob.js | Updated calculation for osparcCredits. | 
| services/static-webserver/client/source/class/osparc/data/Resources.js | Updated endpoints for pipeline actions and active jobs. | 
| services/static-webserver/client/source/class/osparc/data/Job.js | Set default job state and added customMetadata field. | 
Comments suppressed due to low confidence (2)
services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js:600
- The callback in the then() block is not being invoked since it only passes a function reference. Consider changing it to .then(() => this.__onPipelineSubmitted()) to properly execute the callback.
 
osparc.data.Resources.fetch("runPipeline", "startPipeline", params).then(() => this.__onPipelineSubmitted)
services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js:669
- The return statement causes the subsequent code block (lines 671-678) in __requestStopPipeline to be unreachable. Consider removing or repositioning the return statement.
 
return true;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
          
 Indeed. I opened another project to show the Activity Overview, because currently there is a bug when showing the actively running tasks (fix here). Regarding the metadata, we want to expose all the information we have and then discuss what to hide. I take a note 👍  | 
    
          
 | 
    
| 
           @Mergifyio queue  | 
    
          
 ✅ The pull request has been merged automaticallyThe pull request has been merged automatically at d2a092c  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍





What do these changes do?
In this PR we bring the Activity Overview to the project card. Here the
/computationsof the given project are listed.Regarding the Activity Center, it replaces the "Runs and Clusters", and it only shows the active Runs. Also, the
projectCustomMetadatais exposed and project can be cancelled from this view.The osparc credits used by the subtasks are also shown.
Related issue/s
How to test
Dev-ops