Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented May 13, 2025

What do these changes do?

In this PR we bring the Activity Overview to the project card. Here the /computations of the given project are listed.

Regarding the Activity Center, it replaces the "Runs and Clusters", and it only shows the active Runs. Also, the projectCustomMetadata is exposed and project can be cancelled from this view.

The osparc credits used by the subtasks are also shown.

Activities

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this May 13, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels May 13, 2025
@odeimaiz odeimaiz added this to the Bazinga! milestone May 13, 2025
@odeimaiz odeimaiz marked this pull request as ready for review May 13, 2025 14:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces the new Activity Overview view on the project card and updates the Activity Center to display only active runs, alongside several UI and API updates across job- and study-related components.

  • Updated icon paths in LoggerModel and several table files.
  • Refactored Jobs store methods to use active jobs with corresponding renames.
  • Added a new ActivityOverview component and integrated it into resource details, and updated StudyEditor pipeline start/stop flows.

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.

Show a summary per file
File Description
services/static-webserver/client/source/class/osparc/widget/logger/LoggerModel.js Updated icon paths to the new locations.
services/static-webserver/client/source/class/osparc/store/Jobs.js Switched to using active jobs fetch and renamed job addition method.
services/static-webserver/client/source/class/osparc/jobs/SubRunsTableModel.js Changed job state display to use status labels.
services/static-webserver/client/source/class/osparc/jobs/SubRunsTable.js Updated icon paths, adjusted column widths, and added a selection reset before log actions.
services/static-webserver/client/source/class/osparc/jobs/RunsTableModel.js Updated job state display and active job fetch usage.
services/static-webserver/client/source/class/osparc/jobs/RunsTable.js Modified cancel action logic and updated button configurations.
services/static-webserver/client/source/class/osparc/jobs/JobsButton.js Adjusted active job count handling and event listeners.
services/static-webserver/client/source/class/osparc/jobs/ActivityOverview.js New component for displaying activity overview.
services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js Refactored pipeline start/stop functions to use new endpoints and logic.
services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js Integrated Activity Overview page into the resource details view.
services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserBase.js Added null checks for the resources container when managing task cards.
services/static-webserver/client/source/class/osparc/data/SubJob.js Updated calculation for osparcCredits.
services/static-webserver/client/source/class/osparc/data/Resources.js Updated endpoints for pipeline actions and active jobs.
services/static-webserver/client/source/class/osparc/data/Job.js Set default job state and added customMetadata field.
Comments suppressed due to low confidence (2)

services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js:600

  • The callback in the then() block is not being invoked since it only passes a function reference. Consider changing it to .then(() => this.__onPipelineSubmitted()) to properly execute the callback.
osparc.data.Resources.fetch("runPipeline", "startPipeline", params).then(() => this.__onPipelineSubmitted)

services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js:669

  • The return statement causes the subsequent code block (lines 671-678) in __requestStopPipeline to be unreachable. Consider removing or repositioning the return statement.
return true;

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure I saw it correctly in your gif, but the sleepers are showing running time even though they were cancelled no?

image

did you take another project? otherwise that looks wrong.

also I think the metadata should not be shown... but that is not my decision.

@odeimaiz
Copy link
Member Author

not sure I saw it correctly in your gif, but the sleepers are showing running time even though they were cancelled no?

image

did you take another project? otherwise that looks wrong.

also I think the metadata should not be shown... but that is not my decision.

Indeed. I opened another project to show the Activity Overview, because currently there is a bug when showing the actively running tasks (fix here).

Regarding the metadata, we want to expose all the information we have and then discuss what to hide. I take a note 👍

@sonarqubecloud
Copy link

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label May 14, 2025
@odeimaiz
Copy link
Member Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented May 14, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at d2a092c

@odeimaiz odeimaiz requested a review from pcrespov May 14, 2025 06:44
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit d2a092c into ITISFoundation:master May 14, 2025
59 checks passed
@odeimaiz odeimaiz deleted the feature/activities branch May 14, 2025 08:15
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants