Skip to content

✨ task manager improvement: listing /computations/{project_id}/iterations #7669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
May 14, 2025
Merged

✨ task manager improvement: listing /computations/{project_id}/iterations #7669

merged 12 commits into from
May 14, 2025

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented May 13, 2025 •
edited
Loading

What do these changes do?

  • ✨ introduce /computations/{project_id}/iterations for getting Comp Runs history
  • 🐛 Fixes bug when asking for credits from RUT

Related issue/s

How to test

Dev-ops

@matusdrobuliak66 matusdrobuliak66 self-assigned this May 13, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Bazinga! milestone May 13, 2025
@codecov
Copy link

codecov bot commented May 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 60.16260% with 49 lines in your changes missing coverage. Please review.

Project coverage is 87.68%. Comparing base (0fb45a9) to head (9c5194d).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##           master    #7669     +/-   ##
=========================================
  Coverage   87.68%   87.68%             
=========================================
  Files        1745     1794     +49     
  Lines       67358    69341   +1983     
  Branches     1135     1136      +1     
=========================================
+ Hits        59062    60803   +1741     
- Misses       7986     8228    +242     
  Partials      310      310
Flag Coverage Δ
integrationtests 64.78% <14.91%> (-0.19%) ⬇️
unittests 86.90% <60.16%> (+0.03%) ⬆️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library 93.92% <ø> (ø)
pkg_dask_task_models_library 98.48% <ø> (ø)
pkg_models_library 92.87% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.41% <ø> (ø)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library 72.88% <0.00%> (-0.07%) ⬇️
pkg_settings_library 90.90% <ø> (ø)
pkg_simcore_sdk 85.66% <ø> (-0.06%) ⬇️
agent 96.46% <ø> (ø)
api_server 92.50% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.64% <ø> (ø)
clusters_keeper 99.25% <ø> (ø)
dask_sidecar 89.88% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.80% <ø> (ø)
director_v2 91.11% <94.73%> (-0.09%) ⬇️
dynamic_scheduler 96.76% <ø> (ø)
dynamic_sidecar 90.15% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.63% <ø> (ø)
resource_usage_tracker 88.91% <ø> (∅)
storage 87.74% <ø> (+0.24%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.94% <54.73%> (-0.08%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fb45a9...9c5194d. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66 matusdrobuliak66 changed the title WIP: listing task manager improvement ✨ task manager improvement: listing /computations/{project_id}/iterations May 13, 2025
@odeimaiz odeimaiz mentioned this pull request May 14, 2025
Merged
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review May 14, 2025 07:24
@matusdrobuliak66 matusdrobuliak66 requested a review from odeimaiz May 14, 2025 07:27
odeimaiz
odeimaiz approved these changes May 14, 2025
View reviewed changes
Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks

pcrespov
pcrespov reviewed May 14, 2025
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx. left some suggestions

GitHK
GitHK approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@matusdrobuliak66 matusdrobuliak66 requested a review from pcrespov May 14, 2025 10:22
@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) May 14, 2025 10:23
@matusdrobuliak66 matusdrobuliak66 added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:director-v2 issue related with the director-v2 service labels May 14, 2025
@matusdrobuliak66 matusdrobuliak66 added the 🤖-automerge marks PR as ready to be merged for Mergify label May 14, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 14, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@matusdrobuliak66 matusdrobuliak66 merged commit 2be6248 into ITISFoundation:master May 14, 2025
59 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the improve-listing-task-manager-5 branch May 14, 2025 12:17
@odeimaiz odeimaiz mentioned this pull request May 15, 2025
Merged
1 task
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
Closed
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
Closed
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

@sanderegg sanderegg Awaiting requested review from sanderegg sanderegg is a code owner

Assignees

@matusdrobuliak66 matusdrobuliak66

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:director-v2 issue related with the director-v2 service a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Bazinga!

Development

Successfully merging this pull request may close these issues.

Add new endpoint for listing history of runs in project view

5 participants

@matusdrobuliak66 @giancarloromeo @GitHK @pcrespov @odeimaiz