Skip to content

Conversation

@sanderegg
Copy link
Member

@sanderegg sanderegg commented May 13, 2025

What do these changes do?

  • removes deprecated names
  • removes writeTimeout which defaults already to 0 so setting 6h does not really make sense
  • removed idleTimeout of 6 hours that is huge instead of the default of 180s that will close keep alive connections where nothing happens. let's see if this is a problem.

Related issue/s

How to test

Dev-ops

sanderegg added 2 commits May 13, 2025 18:57
and unnecessary timeout for write as this default already to no timeout
@sanderegg sanderegg added this to the Bazinga! milestone May 13, 2025
@sanderegg sanderegg self-assigned this May 13, 2025
@sanderegg sanderegg added the t:maintenance Some planned maintenance work label May 13, 2025
@sonarqubecloud
Copy link

@sanderegg sanderegg merged commit 6906f54 into ITISFoundation:master May 14, 2025
69 checks passed
@sanderegg sanderegg deleted the maintenance/upgrade-simcore-traefik2 branch May 14, 2025 05:43
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.91%. Comparing base (328dac5) to head (c01c180).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7671      +/-   ##
==========================================
- Coverage   87.73%   85.91%   -1.82%     
==========================================
  Files        1793     1776      -17     
  Lines       69226    68838     -388     
  Branches     1135     1123      -12     
==========================================
- Hits        60732    59140    -1592     
- Misses       8184     9388    +1204     
  Partials      310      310              
Flag Coverage Δ
integrationtests 64.96% <ø> (-0.01%) ⬇️
unittests 85.08% <100.00%> (-1.87%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.92% <ø> (ø)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 92.86% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.41% <ø> (ø)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library 72.93% <ø> (-0.02%) ⬇️
pkg_settings_library 90.90% <ø> (ø)
pkg_simcore_sdk 85.48% <ø> (-0.24%) ⬇️
agent 96.46% <ø> (ø)
api_server 92.50% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.64% <ø> (ø)
clusters_keeper 99.25% <ø> (ø)
dask_sidecar 89.65% <ø> (-0.23%) ⬇️
datcore_adapter 98.12% <ø> (ø)
director 76.80% <100.00%> (ø)
director_v2 91.16% <ø> (+0.07%) ⬆️
dynamic_scheduler 96.76% <ø> (ø)
dynamic_sidecar 90.15% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.63% <ø> (ø)
resource_usage_tracker 88.91% <ø> (-0.11%) ⬇️
storage 87.81% <ø> (+0.24%) ⬆️
webclient ∅ <ø> (∅)
webserver 80.02% <ø> (-6.07%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 328dac5...c01c180. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant