🐛 [Frontend] Fixes: Data Browsing #7672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
odeimaiz
requested review from
GitHK,
Copilot,
giancarloromeo,
matusdrobuliak66,
mguidon,
pcrespov and
sanderegg
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a bug in the Data Browsing functionality by ensuring that only the necessary files are requested when browsing folders. Key changes include:
- Refactoring duplicated folder-opening logic into a new __openPath helper method.
- Updating event listeners in TreeFolderView.js to use the new __openPath method for a consistent code path.
- Removing the outdated osparc/dashboard/FoldersTree.js file that is no longer needed.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/file/TreeFolderView.js | Introduces the __openPath helper method to centralize folder-opening logic and streamline event handlers. |
| services/static-webserver/client/source/class/osparc/dashboard/FoldersTree.js | Removes the redundant FoldersTree implementation, simplifying folder management. |
services/static-webserver/client/source/class/osparc/file/TreeFolderView.js
Show resolved
Hide resolved
giancarloromeo
approved these changes
May 14, 2025
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 306fe84 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Reported by @mguidon
Using the folder content viewer (right side of the Data Browser), was not always working, and was requesting more files than required. This PR fixes it.
Related issue/s
How to test
Dev-ops