🐛 [Frontend] Fix: Templates listing #7673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
|
odeimaiz
changed the title
odeimaiz
requested review from
GitHK,
Copilot,
giancarloromeo,
matusdrobuliak66,
mguidon,
pcrespov and
sanderegg
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a lazy-load bug for templates by ensuring that services are properly tagged and that the aliasing logic is updated to reflect the deprecation of the old service alias. Key changes include:
- Setting the "resourceType" property on service objects in the cache.
- Updating the aliasing logic in Utils.js to use "app" instead of "service."
- Enhancing the Dashboard component with a new "preResourcesLoaded" event and guarded resource initialization.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/store/Services.js | Adds a "resourceType" property to service objects before caching. |
| services/static-webserver/client/source/class/osparc/product/Utils.js | Deprecates the service alias in favor of the app alias in resource type mapping. |
| services/static-webserver/client/source/class/osparc/dashboard/SearchBarFilter.js | Updates label generation to use a pre-computed resource alias variable. |
| services/static-webserver/client/source/class/osparc/dashboard/Dashboard.js | Introduces a "preResourcesLoaded" event and adjusts resource initialization based on load state. |
Comments suppressed due to low confidence (1)
services/static-webserver/client/source/class/osparc/dashboard/Dashboard.js:188
- [nitpick] Consider renaming the variable 'preResourcesLoaded' to a more descriptive name such as 'hasPreResourcesLoaded' to improve clarity.
let preResourcesLoaded = false;
services/static-webserver/client/source/class/osparc/dashboard/Dashboard.js
Show resolved
Hide resolved
GitHK
approved these changes
May 14, 2025
matusdrobuliak66
approved these changes
May 14, 2025
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 0fb45a9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In the lazy-load of templates a bug was introduced, the switching and lazy loading of templates would only work after the services were fetched. This issue was detected by the wpt-exposure e2e test and this PR fixes it.
Buggy:
Fixed:
Related issue/s
How to test
Dev-ops