Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented May 15, 2025

What do these changes do?

  • πŸ› fix project-v0.0.1.json schema

Related issue/s

How to test

Dev-ops

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review May 15, 2025 15:16
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented May 15, 2025

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 65.84%. Comparing base (17a8abf) to head (76ee199).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (17a8abf) and HEAD (76ee199). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (17a8abf) HEAD (76ee199)
unittests 31 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7684       +/-   ##
===========================================
- Coverage   87.55%   65.84%   -21.71%     
===========================================
  Files        1802      710     -1092     
  Lines       70121    34049    -36072     
  Branches     1137      170      -967     
===========================================
- Hits        61391    22421    -38970     
- Misses       8420    11570     +3150     
+ Partials      310       58      -252     
Flag Coverage Ξ” *Carryforward flag
integrationtests 63.29% <ΓΈ> (-1.15%) ⬇️ Carriedforward from 17a8abf
unittests 76.80% <ΓΈ> (-9.97%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Components Coverage Ξ”
api βˆ… <ΓΈ> (βˆ…)
pkg_aws_library βˆ… <ΓΈ> (βˆ…)
pkg_dask_task_models_library βˆ… <ΓΈ> (βˆ…)
pkg_models_library βˆ… <ΓΈ> (βˆ…)
pkg_notifications_library βˆ… <ΓΈ> (βˆ…)
pkg_postgres_database βˆ… <ΓΈ> (βˆ…)
pkg_service_integration βˆ… <ΓΈ> (βˆ…)
pkg_service_library βˆ… <ΓΈ> (βˆ…)
pkg_settings_library βˆ… <ΓΈ> (βˆ…)
pkg_simcore_sdk 77.24% <ΓΈ> (-8.25%) ⬇️
agent βˆ… <ΓΈ> (βˆ…)
api_server βˆ… <ΓΈ> (βˆ…)
autoscaling βˆ… <ΓΈ> (βˆ…)
catalog βˆ… <ΓΈ> (βˆ…)
clusters_keeper βˆ… <ΓΈ> (βˆ…)
dask_sidecar βˆ… <ΓΈ> (βˆ…)
datcore_adapter βˆ… <ΓΈ> (βˆ…)
director 76.80% <ΓΈ> (-0.10%) ⬇️
director_v2 77.71% <ΓΈ> (-13.42%) ⬇️
dynamic_scheduler βˆ… <ΓΈ> (βˆ…)
dynamic_sidecar 89.06% <ΓΈ> (-1.10%) ⬇️
efs_guardian βˆ… <ΓΈ> (βˆ…)
invitations βˆ… <ΓΈ> (βˆ…)
payments βˆ… <ΓΈ> (βˆ…)
resource_usage_tracker βˆ… <ΓΈ> (βˆ…)
storage βˆ… <ΓΈ> (βˆ…)
webclient βˆ… <ΓΈ> (βˆ…)
webserver 56.85% <ΓΈ> (-28.99%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 17a8abf...76ee199. Read the comment docs.

πŸš€ New features to boost your workflow:
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still used somewhere? I am suprised :-)(

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) May 15, 2025 15:37
@matusdrobuliak66 matusdrobuliak66 self-assigned this May 15, 2025
@matusdrobuliak66 matusdrobuliak66 added the πŸ€–-automerge marks PR as ready to be merged for Mergify label May 15, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Bazinga! milestone May 15, 2025
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still use that old piece of json???

@matusdrobuliak66 matusdrobuliak66 merged commit a8f1977 into ITISFoundation:master May 15, 2025
90 of 94 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the fix-test branch May 15, 2025 15:40
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

πŸ€–-automerge marks PR as ready to be merged for Mergify

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants