🐛 Fixes WEBSERVER_FUNCTIONS to run in development deploys

[pcrespov]

What do these changes do?

Fixes configuration of WEBSERVER_FUNCTIONS

WEBSERVER_FUNCTIONS was incorrectly configured: it was marked as _X_FEATURE_UNDER_DEVELOPMENT, which is correct, but it was also explicitly set to False.

The _X_FEATURE_UNDER_DEVELOPMENT flag is meant to disable features in production while keeping the actuall setting in development. Explicitly setting WEBSERVER_FUNCTIONS=False will always (either development or production) keep this feature disabled.

• Fixes WEBSERVER_FUNCTIONS such that it only runs if WEBSERVER_DEV_FEATURES_ENABLED=True and otherwise it is disabled.
• ♻️ Cleanup tests and flag names

Side note:

• The mechanism depending on the WEBSERVER_DEV_FEATURES_ENABLED environment variable is INDEED misleading—likely the result of incremental changes without a full review of the underlying logic.
• I will follow up in Improve logic WEBSERVER_DEV_FEATURES_ENABLED: Enforce Automatic Disabling of Under-Development Plugins in Production #7688 and improve this mechanism.
• For now, this PR hsould solve the ongoing issue and unblock @wvangeit and @JavierGOrdonnez .

Related issue/s

How to test

Dev-ops

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.99%. Comparing base (17ccd74) to head (cab2dde).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7687      +/-   ##
==========================================
- Coverage   87.45%   83.99%   -3.46%     
==========================================
  Files        1802      694    -1108     
  Lines       70121    32942   -37179     
  Branches     1137      170     -967     
==========================================
- Hits        61323    27671   -33652     
+ Misses       8488     5214    -3274     
+ Partials      310       57     -253     

Flag	Coverage Δ
integrationtests	64.44% <100.00%> (+1.09%)	⬆️
unittests	87.18% <100.00%> (+0.40%)	⬆️

Components	Coverage Δ
api	∅ <ø> (∅)
pkg_aws_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	∅ <ø> (∅)
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	∅ <ø> (∅)
pkg_service_library	∅ <ø> (∅)
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	77.59% <ø> (-8.13%)	⬇️
agent	∅ <ø> (∅)
api_server	∅ <ø> (∅)
autoscaling	∅ <ø> (∅)
catalog	∅ <ø> (∅)
clusters_keeper	∅ <ø> (∅)
dask_sidecar	∅ <ø> (∅)
datcore_adapter	∅ <ø> (∅)
director	∅ <ø> (∅)
director_v2	77.74% <ø> (-13.37%)	⬇️
dynamic_scheduler	∅ <ø> (∅)
dynamic_sidecar	89.06% <ø> (-1.10%)	⬇️
efs_guardian	∅ <ø> (∅)
invitations	∅ <ø> (∅)
payments	∅ <ø> (∅)
resource_usage_tracker	∅ <ø> (∅)
storage	∅ <ø> (∅)
webclient	∅ <ø> (∅)
webserver	85.82% <100.00%> (+0.32%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17ccd74...cab2dde. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[matusdrobuliak66]

👍

[pcrespov]

@mergify queue

[mergify]

queue

🟠 Waiting for conditions to match

• -closed [📌 queue requirement]
• -conflict [📌 queue requirement]
• -draft [📌 queue requirement]
• any of: [📌 queue -> configuration change requirements]
  • -mergify-configuration-changed
  • check-success = Configuration changed
• any of: [🔀 queue conditions]
  • all of: [📌 queue conditions of queue default]
    • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
    • #approved-reviews-by>=2
    • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
    • #changes-requested-reviews-by=0
    • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
    • #review-threads-unresolved=0
    • -conflict
    • -draft
    • base=master
    • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
    • label!=🤖-do-not-merge
    • label=🤖-automerge
    • any of: [🛡 GitHub branch protection]
      • check-skipped = deploy to dockerhub
      • check-neutral = deploy to dockerhub
      • check-success = deploy to dockerhub
    • any of: [🛡 GitHub branch protection]
      • check-success = system-tests
      • check-neutral = system-tests
      • check-skipped = system-tests
    • any of: [🛡 GitHub branch protection]
      • check-success = unit-tests
      • check-neutral = unit-tests
      • check-skipped = unit-tests
    • any of: [🛡 GitHub branch protection]
      • check-success = check OAS' are up to date
      • check-neutral = check OAS' are up to date
      • check-skipped = check OAS' are up to date
    • any of: [🛡 GitHub branch protection]
      • check-success = integration-tests
      • check-neutral = integration-tests
      • check-skipped = integration-tests
    • any of: [🛡 GitHub branch protection]
      • check-success = build-test-images (frontend) / build-test-images
      • check-neutral = build-test-images (frontend) / build-test-images
      • check-skipped = build-test-images (frontend) / build-test-images

[wvangeit]

Thx

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud