🎨 [Frontend] Filter and patch template types #7690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ak66/osparc-simcore into enh/filter-types
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7690 +/- ##
==========================================
- Coverage 87.57% 87.21% -0.36%
==========================================
Files 1804 1559 -245
Lines 70181 62206 -7975
Branches 1137 608 -529
==========================================
- Hits 61462 54254 -7208
+ Misses 8409 7789 -620
+ Partials 310 163 -147
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
odeimaiz
added
t:enhancement
…ak66/osparc-simcore into enh/filter-types
…nto enh/filter-types
odeimaiz
changed the title
odeimaiz
requested review from
GitHK,
Copilot,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors and extends the handling of template types by replacing legacy template methods with new ones for tutorials and hypertools while also modifying UI components to support the changes. Key updates include:
- Removal of legacy template functions from the store and corresponding updates in NotificationUI and StudyLarge.
- Renaming and refactoring of components and methods to handle Tutorials and Hypertools (e.g. TutorialsList, NewStudies, AppBrowser).
- Endpoint and controller updates to support new filtering and caching mechanisms for template types.
Reviewed Changes
Copilot reviewed 24 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/store/Store.js | Removed obsolete functions (setTemplateState, getTemplate) in favor of new methods. |
| services/static-webserver/client/source/class/osparc/notification/NotificationUI.js | Updated the source of template data to use the new Templates API. |
| services/static-webserver/client/source/class/osparc/info/StudyLarge.js | Replaced legacy __isTemplate checks with usage of getTemplateType for UI adjustments. |
| services/static-webserver/client/source/class/osparc/desktop/organizations/TutorialsList.js | Renamed TemplatesList to TutorialsList and updated filtering and fetching logic. |
| services/static-webserver/client/source/class/osparc/dashboard/* | Updated several dashboard components to use hypertools and tutorials instead of legacy templates. |
| services/static-webserver/client/source/class/osparc/data/model/* | Extended model properties and statics to support new templateType values. |
| services/static-webserver/client/source/class/osparc/data/Resources.js | Updated API endpoint to include the new template_type filter. |
| eslint.config.js | Added ignore paths for client resource output directories. |
Files not reviewed (1)
- .eslintignore: Language not supported
Comments suppressed due to low confidence (2)
services/static-webserver/client/source/class/osparc/desktop/organizations/TutorialsList.js:118
- [nitpick] The variable name 'orgTemplates' is still used in a context handling tutorials; consider renaming it to 'orgTutorials' for improved clarity.
const orgTemplates = tutorials.filter(template => groupId in template["accessRights"]);
services/static-webserver/client/source/class/osparc/dashboard/CardBase.js:165
- [nitpick] The comparison in the 'hypertool' branch directly compares resourceType with appType, which might be confusing. Consider using a comparison against metadata (if available) or clarifying the intent of this check to avoid any potential logic issues.
else if (resourceType === "hypertool") { const matches = (resourceType === appType); return !matches; }
services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserBase.js
Outdated
Show resolved
Hide resolved
|
@Mergifyio queue |
🛑 The pull request has been synchronized by a user |
matusdrobuliak66
approved these changes
May 16, 2025
pcrespov
approved these changes
May 16, 2025
services/static-webserver/client/source/class/osparc/data/model/StudyUI.js
Show resolved
Hide resolved
|
This pull request has been removed from the queue for the following reason: The pull request #7690 has been manually updated. If you want to requeue this pull request, you can post a |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
template_typefilterRelated issue/s
How to test
Dev-ops