Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented May 19, 2025

What do these changes do?

Before bringing the Hypertools and Public Projects sections, the Study browser was only listing studies, the Template browser templates and the Service browser services...

We now have templates in all three browser, but the menu in their cards would still show the browser specific menu. This PR fixes that issue.

Wrong menus:
WrongMenu

Correct menus:
CorrectMenu

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz self-assigned this May 19, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels May 19, 2025
@odeimaiz odeimaiz added this to the Bazinga! milestone May 19, 2025
@odeimaiz odeimaiz marked this pull request as ready for review May 19, 2025 08:18
@odeimaiz odeimaiz changed the title 🎨 [Frontend] Card Menu: Template menu on template cards 🎨 [Frontend] Card Menu: Template menu on template, tutorial and hypertool cards May 19, 2025
@sonarqubecloud
Copy link

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for a new resource type “tutorial” across various browser components, ensuring that cards for templates, tutorials, and hypertools now display a consistent “template” menu instead of the browser‐specific menus. Key changes include adding a new isTutorial helper in Resources.js, updating menu button conditions in several UI components (e.g. CollaboratorListItem.js, Collaborators.js, CardBase.js), and extending utility functions to support the new tutorial resource type.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
osparc/utils/Resources.js Adds a new isTutorial method to identify tutorial resources.
CollaboratorListItem.js, Collaborators.js, CollaboratorsStudy.js Updates resource type checks to include “tutorial” in appropriate arrays.
NewCollaboratorsManager.js Refactors sharing logic for tutorials using a switch statement.
Utils.js Adds getTutorialAlias and reorders alias functions to include tutorials.
TutorialsList.js, TutorialBrowser.js, and related dashboard components Update resource type attributes from “template” to “tutorial” and adjust event handling accordingly.
StudyBrowser.js, CardBase.js, ListButtonItem.js, GridButtonItem.js, AppBrowser.js Modify card menu population logic and resource type checks to accommodate the tutorial resource type.

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label May 19, 2025
@odeimaiz
Copy link
Member Author

@Mergifyio queue

Copy link
Contributor

@giancarloromeo giancarloromeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mergify
Copy link
Contributor

mergify bot commented May 19, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 97fafc4

@mergify mergify bot merged commit 97fafc4 into ITISFoundation:master May 19, 2025
59 checks passed
@odeimaiz odeimaiz deleted the enh/template-menu branch May 19, 2025 08:38
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants