-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 [Frontend] Card Menu: Template menu on template, tutorial and hypertool cards #7696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces support for a new resource type “tutorial” across various browser components, ensuring that cards for templates, tutorials, and hypertools now display a consistent “template” menu instead of the browser‐specific menus. Key changes include adding a new isTutorial helper in Resources.js, updating menu button conditions in several UI components (e.g. CollaboratorListItem.js, Collaborators.js, CardBase.js), and extending utility functions to support the new tutorial resource type.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| osparc/utils/Resources.js | Adds a new isTutorial method to identify tutorial resources. |
| CollaboratorListItem.js, Collaborators.js, CollaboratorsStudy.js | Updates resource type checks to include “tutorial” in appropriate arrays. |
| NewCollaboratorsManager.js | Refactors sharing logic for tutorials using a switch statement. |
| Utils.js | Adds getTutorialAlias and reorders alias functions to include tutorials. |
| TutorialsList.js, TutorialBrowser.js, and related dashboard components | Update resource type attributes from “template” to “tutorial” and adjust event handling accordingly. |
| StudyBrowser.js, CardBase.js, ListButtonItem.js, GridButtonItem.js, AppBrowser.js | Modify card menu population logic and resource type checks to accommodate the tutorial resource type. |
services/static-webserver/client/source/class/osparc/dashboard/StudyBrowser.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/dashboard/TutorialBrowser.js
Show resolved
Hide resolved
|
@Mergifyio queue |
giancarloromeo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 97fafc4 |



What do these changes do?
Before bringing the Hypertools and Public Projects sections, the Study browser was only listing studies, the Template browser templates and the Service browser services...
We now have templates in all three browser, but the menu in their cards would still show the browser specific menu. This PR fixes that issue.
Wrong menus:

Correct menus:

Related issue/s
How to test
Dev-ops