Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented May 19, 2025

What do these changes do?

1st draft of the Pending Users section in the PO Center (it is only available if dev_features_enabled)

PendingUsers

Related issue/s

How to test

Dev-ops

@odeimaiz odeimaiz added this to the Bazinga! milestone May 19, 2025
@odeimaiz odeimaiz self-assigned this May 19, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels May 19, 2025
@odeimaiz odeimaiz requested a review from Copilot May 19, 2025 10:26
@odeimaiz odeimaiz marked this pull request as ready for review May 19, 2025 10:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new Pending Users section to the PO Center frontend, providing a UI to view and manage users pending activation. It also updates existing center pages and API endpoints to support approving, rejecting, or resending emails to pending users.

  • Added a new view (UsersPending.js) for pending users with approve, reject, and resend email buttons.
  • Updated POCenter.js to include new tabs for active and pending users.
  • Adjusted related UI elements and API endpoints in Resources.js and ServicesInStudy.js.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
osparc/po/UsersPending.js New view for pending users with interactive buttons and sample data.
osparc/po/POCenterWindow.js Increased window width from 800 to 900.
osparc/po/POCenter.js Renamed and added functions to separate active and pending users views.
osparc/metadata/ServicesInStudy.js Updated icon size for info button consistency.
osparc/info/ServiceLarge.js Removed unused raw metadata view function.
osparc/data/Resources.js Added new API endpoints for pending user actions.
Comments suppressed due to low confidence (3)

services/static-webserver/client/source/class/osparc/po/POCenter.js:29

  • [nitpick] Renaming from __addUsersPage to __addActiveUsersPage enhances clarity. Please ensure that all related documentation and internal references are updated accordingly.
this.__addActiveUsersPage();

services/static-webserver/client/source/class/osparc/info/ServiceLarge.js:457

  • [nitpick] The removal of __createRawMetadata should be reviewed to confirm that no dependent components rely on its functionality. If fully deprecated, consider cleaning up any residual calls or documentation.
/* __createRawMetadata function removed */

services/static-webserver/client/source/class/osparc/metadata/ServicesInStudy.js:135

  • [nitpick] The icon size has been updated from 14 to 16. Please verify that this size change aligns with the overall design and UI guidelines of the application.
const infoButton = new qx.ui.form.Button(null, "@MaterialIcons/info_outline/16");

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@odeimaiz odeimaiz added the 🤖-automerge marks PR as ready to be merged for Mergify label May 19, 2025
@odeimaiz
Copy link
Member Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented May 19, 2025

queue

🛑 The pull request has been synchronized by a user

@odeimaiz odeimaiz requested a review from pcrespov May 19, 2025 14:05
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@mergify
Copy link
Contributor

mergify bot commented May 19, 2025

This pull request has been removed from the queue for the following reason: pull request manually updated.

The pull request #7699 has been manually updated.

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@odeimaiz
Copy link
Member Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented May 19, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 6d446c9

@sonarqubecloud
Copy link

@mergify mergify bot merged commit 6d446c9 into ITISFoundation:master May 19, 2025
59 checks passed
@odeimaiz odeimaiz deleted the feature/pending-users branch May 19, 2025 16:30
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants