Skip to content

Conversation

@bisgaard-itis
Copy link
Contributor

What do these changes do?

  • "Resolve" endpoint when recording Prometheus metrics to avoid excessive number of labels.

Related issue/s

How to test

Dev-ops

@bisgaard-itis bisgaard-itis requested a review from pcrespov as a code owner May 20, 2025 10:38
@bisgaard-itis bisgaard-itis self-assigned this May 20, 2025
@bisgaard-itis bisgaard-itis added the bug buggy, it does not work as expected label May 20, 2025
@bisgaard-itis bisgaard-itis added this to the Bazinga! milestone May 20, 2025
@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.16%. Comparing base (3c12ac2) to head (4f4eb75).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7704      +/-   ##
==========================================
- Coverage   87.46%   87.16%   -0.31%     
==========================================
  Files        1820     1431     -389     
  Lines       70574    59489   -11085     
  Branches     1148      605     -543     
==========================================
- Hits        61726    51851    -9875     
+ Misses       8536     7452    -1084     
+ Partials      312      186     -126     
Flag Coverage Δ
integrationtests 64.41% <ø> (-0.06%) ⬇️
unittests 86.22% <72.72%> (-0.46%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 72.32% <72.72%> (-0.04%) ⬇️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.07% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 91.59% <ø> (ø)
autoscaling 96.07% <ø> (ø)
catalog 92.70% <ø> (ø)
clusters_keeper 99.25% <ø> (ø)
dask_sidecar 91.44% <ø> (-0.23%) ⬇️
datcore_adapter 98.12% <ø> (ø)
director 76.78% <ø> (ø)
director_v2 91.04% <ø> (+0.01%) ⬆️
dynamic_scheduler 96.76% <ø> (ø)
dynamic_sidecar 90.18% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.63% <ø> (ø)
resource_usage_tracker 89.02% <ø> (-0.11%) ⬇️
storage 87.49% <ø> (-0.25%) ⬇️
webclient ∅ <ø> (∅)
webserver 85.62% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c12ac2...4f4eb75. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx!

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) May 20, 2025 11:42
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bisgaard-itis bisgaard-itis merged commit c591a6f into ITISFoundation:master May 20, 2025
94 of 95 checks passed
@bisgaard-itis bisgaard-itis deleted the use-resolved-path-in-prometheus-metrics branch May 20, 2025 14:01
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug buggy, it does not work as expected

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants