Skip to content

Conversation

@bisgaard-itis
Copy link
Contributor

What do these changes do?

  • Remove histogram with many buckets and improve histogram with endpoints labels in prometheus metrics in order to create better heatmaps our grafana dashboard

Related issue/s

How to test

Dev-ops

@bisgaard-itis bisgaard-itis requested a review from pcrespov as a code owner May 20, 2025 14:25
@bisgaard-itis bisgaard-itis requested a review from sanderegg May 20, 2025 14:25
@bisgaard-itis bisgaard-itis self-assigned this May 20, 2025
@bisgaard-itis bisgaard-itis added this to the Bazinga! milestone May 20, 2025
@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (1fa455a) to head (1556ccd).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7706      +/-   ##
==========================================
- Coverage   87.35%   87.14%   -0.21%     
==========================================
  Files        1839     1431     -408     
  Lines       71084    59486   -11598     
  Branches     1203      605     -598     
==========================================
- Hits        62095    51839   -10256     
+ Misses       8661     7461    -1200     
+ Partials      328      186     -142     
Flag Coverage Δ
integrationtests 64.41% <ø> (-0.08%) ⬇️
unittests 86.21% <ø> (-0.36%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 72.34% <ø> (+0.01%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 84.89% <ø> (-0.06%) ⬇️
agent 96.46% <ø> (ø)
api_server 91.59% <ø> (ø)
autoscaling 96.07% <ø> (ø)
catalog 92.70% <ø> (ø)
clusters_keeper 99.25% <ø> (ø)
dask_sidecar 91.67% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.78% <ø> (ø)
director_v2 91.01% <ø> (-0.06%) ⬇️
dynamic_scheduler 96.76% <ø> (ø)
dynamic_sidecar 90.18% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.63% <ø> (ø)
resource_usage_tracker 88.86% <ø> (-0.17%) ⬇️
storage 87.56% <ø> (+0.07%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.59% <ø> (-0.03%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa455a...1556ccd. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧨 thanks!

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) May 21, 2025 11:31
@sonarqubecloud
Copy link

@bisgaard-itis bisgaard-itis merged commit 00e6733 into ITISFoundation:master May 21, 2025
95 checks passed
@bisgaard-itis bisgaard-itis deleted the only-keep-histogram-with-endpoint-labels branch May 21, 2025 12:12
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants