Skip to content

Conversation

@wvangeit
Copy link
Contributor

What do these changes do?

As pointed out by PC, two func job collections were missing changelog info

Dev-ops

No changes

@wvangeit wvangeit requested a review from pcrespov as a code owner May 20, 2025 15:48
@wvangeit wvangeit self-assigned this May 20, 2025
@wvangeit wvangeit added the a:apiserver api-server service label May 20, 2025
@wvangeit wvangeit added this to the Bazinga! milestone May 20, 2025
@wvangeit
Copy link
Contributor Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented May 20, 2025

queue

🛑 The pull request has been removed from the queue default

The pull request can't be updated.

You can take a look at Queue: Embarked in merge queue check runs for more details about the failure.

@wvangeit wvangeit added the 🤖-automerge marks PR as ready to be merged for Mergify label May 20, 2025
@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.04%. Comparing base (afe3750) to head (258ebe9).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (afe3750) and HEAD (258ebe9). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (afe3750) HEAD (258ebe9)
unittests 32 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7708       +/-   ##
===========================================
- Coverage   87.35%   69.04%   -18.32%     
===========================================
  Files        1839      802     -1037     
  Lines       71084    36858    -34226     
  Branches     1203      174     -1029     
===========================================
- Hits        62097    25449    -36648     
- Misses       8659    11351     +2692     
+ Partials      328       58      -270     
Flag Coverage Δ
integrationtests 64.37% <ø> (-0.11%) ⬇️
unittests 91.59% <ø> (+5.02%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.89% <ø> (-8.24%) ⬇️
agent ∅ <ø> (∅)
api_server 91.59% <ø> (ø)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 77.73% <ø> (-13.36%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.83% <ø> (-1.36%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 58.52% <ø> (-27.09%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afe3750...258ebe9. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@mergify
Copy link
Contributor

mergify bot commented May 21, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@wvangeit
Copy link
Contributor Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented May 21, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 01ef5cf

@sonarqubecloud
Copy link

@mergify mergify bot merged commit 01ef5cf into ITISFoundation:master May 21, 2025
93 of 96 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@wvangeit wvangeit deleted the fix_funcol_changelog branch August 5, 2025 09:39
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:apiserver api-server service Meta-modeling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants