-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 [Frontend] Runs with children #7712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 [Frontend] Runs with children #7712
Conversation
…imcore into enh/runs-with-children
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the frontend to support the new URL parameter “include_children” for improved search and filtering of runs and sub-runs. Key changes include refactoring API endpoints from “jobs” to “runs”, propagating the new includeChildren parameter through various components (data store, table models, and browser components), and updating URL endpoints accordingly.
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| DisabledPlugins.js | Contains a duplicate key definition that may cause conflicts. |
| Jobs.js | Refactors API calls to use “runs” endpoints and propagates includeChildren. |
| SubRunsTableModel.js, SubRunsTable.js, SubRunsBrowser.js, RunsTableModel.js, RunsTable.js, RunsBrowser.js, ActivityOverview.js | Updates constructors and API calls to support the new includeChildren parameter. |
| Resources.js | Updates endpoint URLs to append the include_children parameter as required. |
services/static-webserver/client/source/class/osparc/utils/DisabledPlugins.js
Outdated
Show resolved
Hide resolved
|
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested 👍
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 9188df0 |
|
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚸



What do these changes do?
Following #7718, use the new url parameter
include_childrenRelated issue/s
How to test
Dev-ops