🎨 [Frontend] Filter Runs #7728
Merged
🎨 [Frontend] Filter Runs #7728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new fetchJobsLatest method supporting server-side filtering and wires it through the UI, replacing the old fetchJobsActive calls.
- Renames and extends the Jobs store fetch method to accept filter parameters
- Updates table model and buttons to use
fetchJobsLatestwith filters - Adds a placeholder (and temporary hide) for the filter field and extends the backend endpoint
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/store/Jobs.js | Renamed fetchJobsActive to fetchJobsLatest and added a filters parameter |
| services/static-webserver/client/source/class/osparc/jobs/RunsTableModel.js | Updated to construct and pass filters to fetchJobsLatest; added apply handler to refresh on filter changes |
| services/static-webserver/client/source/class/osparc/jobs/RunsBrowser.js | Set placeholder text on the filter field and temporarily hide it until backend is ready |
| services/static-webserver/client/source/class/osparc/jobs/JobsButton.js | Switched initial job fetch to call the new fetchJobsLatest |
| services/static-webserver/client/source/class/osparc/desktop/MainPage.js | Updated preload to use fetchJobsLatest instead of the old method |
| services/static-webserver/client/source/class/osparc/data/Resources.js | Extended getPageLatest endpoint URL with a filters query parameter |
services/static-webserver/client/source/class/osparc/jobs/RunsTableModel.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/jobs/RunsBrowser.js
Show resolved
Hide resolved
pcrespov
reviewed
May 22, 2025
Member
pcrespov
left a comment
pcrespov
left a comment
There was a problem hiding this comment.
- its not very clear what kind of text i can add in this search bar. e.g. is it a title? do i have reserved words or key-value syntax e.g.
state:open, can I use a pattern e.g.foo*? is it fuzzy search ? - Can I filter by column attribute? e.g. like
Member
Author
The filter placeholder says "Filter by name or ID"... We can later go fancy. |
Member
Author
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 14e0a66 |
matusdrobuliak66
approved these changes
May 23, 2025
GitHK
approved these changes
May 23, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR adds some text filtering to the
computations/-/iterations/latestendpoint. The textfield filter is for now hidden, when the filtering in the backend is implemented, the line that hides it should be removed.Related issue/s
How to test
Dev-ops