Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

What do these changes do?

  • 🐛 Fix listing (currently, project activity only shows the current user's actions; activities of other users are not visible)

Related issue/s

How to test

Dev-ops

@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review May 22, 2025 14:38
@matusdrobuliak66 matusdrobuliak66 requested a review from odeimaiz May 22, 2025 14:40
@matusdrobuliak66 matusdrobuliak66 self-assigned this May 22, 2025
@matusdrobuliak66 matusdrobuliak66 added the a:director-v2 issue related with the director-v2 service label May 22, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Bazinga! milestone May 22, 2025
@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.24%. Comparing base (14e0a66) to head (c4b0577).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (14e0a66) and HEAD (c4b0577). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (14e0a66) HEAD (c4b0577)
unittests 32 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7732       +/-   ##
===========================================
- Coverage   87.37%   69.24%   -18.13%     
===========================================
  Files        1838      700     -1138     
  Lines       71325    33274    -38051     
  Branches     1202      174     -1028     
===========================================
- Hits        62318    23041    -39277     
- Misses       8677    10175     +1498     
+ Partials      330       58      -272     
Flag Coverage Δ
integrationtests 64.31% <28.57%> (-0.02%) ⬇️
unittests 84.36% <85.71%> (-2.24%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.95% <ø> (-8.12%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 90.97% <85.71%> (-0.05%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.83% <ø> (-1.36%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 58.44% <ø> (-27.29%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14e0a66...c4b0577. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • you should add a test that hits this condition. That is why you did not detect it last time!

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also appreciate a test to go with this change

@matusdrobuliak66
Copy link
Collaborator Author

@mergify

@mergify
Copy link
Contributor

mergify bot commented May 23, 2025

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@sonarqubecloud
Copy link

@matusdrobuliak66
Copy link
Collaborator Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented May 23, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • label=🤖-automerge
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) May 23, 2025 09:04
@matusdrobuliak66 matusdrobuliak66 merged commit 78abf4b into ITISFoundation:master May 23, 2025
92 of 95 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:director-v2 issue related with the director-v2 service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants