🐛 web-api: wallet update operation has now optional thumbnail

[pcrespov]

What do these changes do?

Front-end is not respecting OAS that requires thumbnail in the body leading to

{
    "error": {
        "status": 422,
        "errors": [
            {
                "code": "missing",
                "message": "Field required",
                "resource": "/v0/wallets/8",
                "field": "thumbnail"
            }
        ]
    }
}

Fixes the issue by dropping the requirement on thumbnail

Suggestions to follow up

• Replace PATCH instead of PUT

Related issue/s

• Resolves Rename wallet #7680

How to test

cd services/web/server
make install-dev
pytest -vv tests/unit -k test_update_wallet_without_thumbnail

Dev-ops

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.91%. Comparing base (78abf4b) to head (d88e478).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7736      +/-   ##
==========================================
+ Coverage   87.38%   88.91%   +1.53%     
==========================================
  Files        1838     1458     -380     
  Lines       71336    60494   -10842     
  Branches     1202      474     -728     
==========================================
- Hits        62335    53790    -8545     
+ Misses       8671     6584    -2087     
+ Partials      330      120     -210     

Flag	Coverage Δ
integrationtests	64.27% <ø> (-0.01%)	⬇️
unittests	88.02% <100.00%> (+1.42%)	⬆️

Components	Coverage Δ
api	∅ <ø> (∅)
pkg_aws_library	∅ <ø> (∅)
pkg_dask_task_models_library	∅ <ø> (∅)
pkg_models_library	93.11% <100.00%> (ø)
pkg_notifications_library	∅ <ø> (∅)
pkg_postgres_database	∅ <ø> (∅)
pkg_service_integration	69.92% <ø> (ø)
pkg_service_library	∅ <ø> (∅)
pkg_settings_library	∅ <ø> (∅)
pkg_simcore_sdk	85.07% <ø> (ø)
agent	96.46% <ø> (ø)
api_server	91.58% <ø> (ø)
autoscaling	96.07% <ø> (ø)
catalog	92.29% <ø> (ø)
clusters_keeper	99.25% <ø> (ø)
dask_sidecar	91.67% <ø> (ø)
datcore_adapter	98.12% <ø> (ø)
director	76.87% <ø> (ø)
director_v2	90.99% <ø> (-0.02%)	⬇️
dynamic_scheduler	96.76% <ø> (ø)
dynamic_sidecar	90.18% <ø> (ø)
efs_guardian	89.79% <ø> (ø)
invitations	93.28% <ø> (ø)
payments	92.63% <ø> (ø)
resource_usage_tracker	89.13% <ø> (+0.05%)	⬆️
storage	87.56% <ø> (-0.25%)	⬇️
webclient	∅ <ø> (∅)
webserver	85.70% <ø> (-0.01%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78abf4b...d88e478. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[pcrespov]

@mergify queue

[mergify]

queue

🛑 The pull request could not be merged

This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 3 of 6 required status checks are expected.)

[sanderegg]

thanks!

[matusdrobuliak66]

👍

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[mergify]

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #7736 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 3 of 6 required status checks are expected.).

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

[pcrespov]

@Mergifyio requeue

[mergify]

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request.

[mergify]

queue

🛑 The pull request could not be merged

This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 6 required status checks are expected.)

[mergify]

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #7736 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 2 of 6 required status checks are expected.).

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.