🎨 dynamic-sidecar prints disk usage on boot #7740
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a startup log of current disk usage and refactors the disk usage monitor registration.
- Introduces
_display_current_disk_usageto log disk stats on application startup. - Refactors
_disk_usage.pyto separate monitor creation (create_disk_usage_monitor), retrieval (get_disk_usage_monitor), and setup. - Adjusts application initialization order by moving
setup_system_monitorafter mounting volumes.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| modules/system_monitor/_setup.py | Added display helper, conditional setup, and startup handler for disk usage logging |
| modules/system_monitor/_disk_usage.py | Split monitor creation/get, renamed and reordered methods, consolidated setup handlers |
| core/application.py | Moved setup_system_monitor call below setup_mounted_fs |
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/modules/system_monitor/_setup.py
Show resolved
Hide resolved
services/dynamic-sidecar/src/simcore_service_dynamic_sidecar/core/application.py
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7740 +/- ##
===========================================
- Coverage 87.32% 66.54% -20.79%
===========================================
Files 1838 700 -1138
Lines 71431 33297 -38134
Branches 1214 174 -1040
===========================================
- Hits 62379 22156 -40223
- Misses 8710 11083 +2373
+ Partials 342 58 -284
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
added 4 commits
May 23, 2025 08:25
GitHK
requested review from
bisgaard-itis,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
Contributor
Author
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at cb35a6e |
pcrespov
approved these changes
May 23, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
To help with system debugging, when dynamic-sidecar starts it will print the available disk space, before it does any operation which requires disk space.
Related issue/s
How to test
Dev-ops