✨ notifications-library: default email templates for on_account_approved, on_account_denied

[pcrespov]

What do these changes do?

• ✨ default email templates for on_account_approved, on_account_denied
  • 
  • 
• ♻️ renamed template for account-request.
• ♻️ adapted product defaults
• ♻️ extended tests for new templates

Related issue/s

• Task of https://github.com/ITISFoundation/private-issues/issues/23

How to test

cd packages/notifications-library
make install-dev
# copy one valid repo.config in place and rename as .secrets
pytest --external-envfile=.secrets --faker-support-email=<support-email>  --faker-user-email=<target-email>  tests/email

Dev-ops

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.36%. Comparing base (6105d2e) to head (a07ecc4).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #7744      +/-   ##
==========================================
+ Coverage   87.32%   87.36%   +0.04%     
==========================================
  Files        1838     1831       -7     
  Lines       71454    71264     -190     
  Branches     1214     1214              
==========================================
- Hits        62394    62257     -137     
+ Misses       8718     8665      -53     
  Partials      342      342              

Flag	Coverage Δ
integrationtests	64.45% <ø> (+0.04%)	⬆️
unittests	86.58% <100.00%> (+0.04%)	⬆️

Components	Coverage Δ
api	∅ <ø> (∅)
pkg_aws_library	93.92% <ø> (ø)
pkg_dask_task_models_library	79.55% <ø> (ø)
pkg_models_library	93.11% <ø> (ø)
pkg_notifications_library	85.26% <100.00%> (ø)
pkg_postgres_database	88.61% <ø> (ø)
pkg_service_integration	69.92% <ø> (ø)
pkg_service_library	71.86% <ø> (ø)
pkg_settings_library	90.90% <ø> (ø)
pkg_simcore_sdk	85.13% <ø> (+0.05%)	⬆️
agent	96.46% <ø> (ø)
api_server	91.58% <ø> (ø)
autoscaling	96.07% <ø> (ø)
catalog	92.29% <ø> (ø)
clusters_keeper	99.25% <ø> (ø)
dask_sidecar	91.67% <ø> (ø)
datcore_adapter	98.12% <ø> (ø)
director	76.78% <ø> (-0.10%)	⬇️
director_v2	91.00% <ø> (+0.01%)	⬆️
dynamic_scheduler	96.76% <ø> (ø)
dynamic_sidecar	90.19% <ø> (ø)
efs_guardian	89.79% <ø> (ø)
invitations	93.28% <ø> (ø)
payments	92.63% <ø> (ø)
resource_usage_tracker	89.13% <ø> (+0.05%)	⬆️
storage	87.81% <ø> (+0.31%)	⬆️
webclient	∅ <ø> (∅)
webserver	85.70% <ø> (-0.01%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6105d2e...a07ecc4. Read the comment docs.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[pcrespov]

@Mergifyio queue

[mergify]

queue

🟠 Waiting for conditions to match

• -closed [📌 queue requirement]
• any of: [🔀 queue conditions]
  • all of: [📌 queue conditions of queue default]
    • label=🤖-automerge
    • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
    • #approved-reviews-by>=2
    • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
    • #changes-requested-reviews-by=0
    • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
    • #review-threads-unresolved=0
    • -conflict
    • -draft
    • base=master
    • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
    • label!=🤖-do-not-merge
    • any of: [🛡 GitHub branch protection]
      • check-skipped = deploy to dockerhub
      • check-neutral = deploy to dockerhub
      • check-success = deploy to dockerhub
    • any of: [🛡 GitHub branch protection]
      • check-success = system-tests
      • check-neutral = system-tests
      • check-skipped = system-tests
    • any of: [🛡 GitHub branch protection]
      • check-success = unit-tests
      • check-neutral = unit-tests
      • check-skipped = unit-tests
    • any of: [🛡 GitHub branch protection]
      • check-success = check OAS' are up to date
      • check-neutral = check OAS' are up to date
      • check-skipped = check OAS' are up to date
    • any of: [🛡 GitHub branch protection]
      • check-success = integration-tests
      • check-neutral = integration-tests
      • check-skipped = integration-tests
    • any of: [🛡 GitHub branch protection]
      • check-success = build-test-images (frontend) / build-test-images
      • check-neutral = build-test-images (frontend) / build-test-images
      • check-skipped = build-test-images (frontend) / build-test-images
• -conflict [📌 queue requirement]
• -draft [📌 queue requirement]
• any of: [📌 queue -> configuration change requirements]
  • -mergify-configuration-changed
  • check-success = Configuration changed

[GitHK]

I am saddened to see that this is not part of the notifications service 😢

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
3 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud