-
Notifications
You must be signed in to change notification settings - Fork 32
✨ Front-end: Drafts "Pending Users" view on the PO center #7745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request enhances the PO center by adding new user invitation and approval features while refining the display of pending and reviewed user accounts. Key changes include:
- A new invitation form and approval flow with a pop-up window for input.
- Addition of a reload button to refresh the pending users layout.
- Merging user data from both pending and reviewed endpoints and updating the header labels accordingly.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/po/UsersPending.js | Added invitation form creation, reload button, and updated user row rendering with accountRequestStatus usage. |
| services/static-webserver/client/source/class/osparc/data/Resources.js | Introduced a new getReviewedUsers endpoint to fetch reviewed user accounts. |
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will take over and add some changes in the backend
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE this is a draft UI on a backend that is also missing features.
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at e53c704 |
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really a draft is it?
@sanderegg IMO there are some features missing. That is why i call it a draft or if you like a first version of it |
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so put it in.
|



What do these changes do?
Drafts the "pending users" view on the PO center
Related issue/s
How to test
Manually tested against available backend
{ "firstName": "John", "lastName": "Smith", "email": "[email protected]", "phone": null, "organization": "Foo", "address": "", "city": "Baltimore", "postalCode": "", "country": "USA", "application": "other", "hear": "Other", "privacyPolicy": true }Dev-ops
None