Skip to content

Conversation

@odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented May 23, 2025

What do these changes do?

Drafts the "pending users" view on the PO center

image

Related issue/s

How to test

Manually tested against available backend

  • Login as PO
  • Open PO center
  • Register a new user (NOTE form still not in connected)
{
  "firstName": "John",
  "lastName": "Smith",
  "email": "[email protected]",
  "phone": null,
  "organization": "Foo",
  "address": "",
  "city": "Baltimore",
  "postalCode": "",
  "country": "USA",
  "application": "other",
  "hear": "Other",
  "privacyPolicy": true
}
  • Switch to PENDING view
  • Load button
  • Check info button
  • Take an action Approve/Reject (NOTE: for not it cannot be undone)
    • Approve:
      • add invitation info
      • invitation email is sent (NOTE: still not connected)
    • Reject
      • should prompt are you sure?

Dev-ops

None

@odeimaiz odeimaiz requested review from Copilot and pcrespov May 23, 2025 12:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request enhances the PO center by adding new user invitation and approval features while refining the display of pending and reviewed user accounts. Key changes include:

  • A new invitation form and approval flow with a pop-up window for input.
  • Addition of a reload button to refresh the pending users layout.
  • Merging user data from both pending and reviewed endpoints and updating the header labels accordingly.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
services/static-webserver/client/source/class/osparc/po/UsersPending.js Added invitation form creation, reload button, and updated user row rendering with accountRequestStatus usage.
services/static-webserver/client/source/class/osparc/data/Resources.js Introduced a new getReviewedUsers endpoint to fetch reviewed user accounts.

@pcrespov pcrespov assigned pcrespov and odeimaiz and unassigned pcrespov May 23, 2025
@pcrespov pcrespov added this to the Bazinga! milestone May 23, 2025
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels May 23, 2025
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take over and add some changes in the backend

@pcrespov pcrespov changed the title Enh/po center ✨ Front-end: Drafts review accounts table for PO center May 27, 2025
@pcrespov pcrespov marked this pull request as ready for review May 27, 2025 15:16
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE this is a draft UI on a backend that is also missing features.

@pcrespov pcrespov changed the title ✨ Front-end: Drafts review accounts table for PO center ✨ Front-end: Drafts "Pending Users" view on the PO center May 27, 2025
@pcrespov
Copy link
Member

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented May 27, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at e53c704

@pcrespov pcrespov added the 🤖-automerge marks PR as ready to be merged for Mergify label May 27, 2025
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really a draft is it?

@pcrespov
Copy link
Member

not really a draft is it?

@sanderegg IMO there are some features missing. That is why i call it a draft or if you like a first version of it

@pcrespov pcrespov requested a review from sanderegg May 28, 2025 07:25
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so put it in.

@sonarqubecloud
Copy link

@mergify mergify bot merged commit e53c704 into ITISFoundation:master May 28, 2025
59 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants