Skip to content

Conversation

@wvangeit
Copy link
Contributor

What do these changes do?

As requested by @JavierGOrdonnez , a filter is now added to list job collection to contain a certain function id.

Related issue/s

ITISFoundation/osparc-issues#1884 (comment)

How to test

Run apiserver and webserver unit tests.

@wvangeit wvangeit added this to the Bazinga! milestone May 23, 2025
@wvangeit wvangeit self-assigned this May 23, 2025
@wvangeit wvangeit added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label May 23, 2025
@wvangeit wvangeit added a:api framework api, data schemas, a:apiserver api-server service 🤖-automerge marks PR as ready to be merged for Mergify labels May 23, 2025
@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.33%. Comparing base (aec4c1e) to head (00878c5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7746      +/-   ##
==========================================
+ Coverage   87.31%   87.33%   +0.01%     
==========================================
  Files        1838     1638     -200     
  Lines       71454    66789    -4665     
  Branches     1214      916     -298     
==========================================
- Hits        62392    58328    -4064     
+ Misses       8720     8198     -522     
+ Partials      342      263      -79     
Flag Coverage Δ
integrationtests 64.43% <25.00%> (+0.06%) ⬆️
unittests 86.50% <96.87%> (-0.04%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 93.08% <100.00%> (-0.04%) ⬇️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library 71.86% <ø> (ø)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.13% <ø> (ø)
agent 96.46% <ø> (ø)
api_server 91.79% <100.00%> (+0.20%) ⬆️
autoscaling 96.07% <ø> (ø)
catalog 92.29% <ø> (ø)
clusters_keeper 99.25% <ø> (ø)
dask_sidecar 91.67% <ø> (+0.22%) ⬆️
datcore_adapter 98.12% <ø> (ø)
director 76.78% <ø> (ø)
director_v2 91.00% <ø> (-0.05%) ⬇️
dynamic_scheduler 96.76% <ø> (ø)
dynamic_sidecar 90.19% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.63% <ø> (ø)
resource_usage_tracker 89.13% <ø> (+0.21%) ⬆️
storage 87.56% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 85.70% <87.50%> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8362d80...00878c5. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wvangeit
Copy link
Contributor Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented May 23, 2025

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at c01b1d3

@wvangeit wvangeit changed the title Add has_functionid filter to function job collection filtering ✨ Add has_function_id filter to function job collection filtering ✨ May 23, 2025
@wvangeit wvangeit requested a review from JavierGOrdonnez May 23, 2025 13:17
@sonarqubecloud
Copy link

@mergify mergify bot merged commit c01b1d3 into ITISFoundation:master May 26, 2025
95 of 96 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@wvangeit wvangeit deleted the add_funccoll_filter branch August 5, 2025 09:39
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:api framework api, data schemas, a:apiserver api-server service a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants