-
Notifications
You must be signed in to change notification settings - Fork 32
Add has_function_id filter to function job collection filtering ✨ #7746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7746 +/- ##
==========================================
+ Coverage 87.31% 87.33% +0.01%
==========================================
Files 1838 1638 -200
Lines 71454 66789 -4665
Branches 1214 916 -298
==========================================
- Hits 62392 58328 -4064
+ Misses 8720 8198 -522
+ Partials 342 263 -79
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…ore into add_funccoll_filter
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at c01b1d3 |
…ore into add_funccoll_filter
…ore into add_funccoll_filter
...pi-server/src/simcore_service_api_server/api/dependencies/models_schemas_function_filters.py
Outdated
Show resolved
Hide resolved
...pi-server/src/simcore_service_api_server/api/dependencies/models_schemas_function_filters.py
Show resolved
Hide resolved
…ore into add_funccoll_filter
|



What do these changes do?
As requested by @JavierGOrdonnez , a filter is now added to list job collection to contain a certain function id.
Related issue/s
ITISFoundation/osparc-issues#1884 (comment)
How to test
Run apiserver and webserver unit tests.