Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented May 26, 2025

What do these changes do?

  • Removes dev-feature mark from WEBSERVER_FUNCTION
  • Exposes WEBSERVER_FUNCTION to the wb-api-server simcore service. Everywhere else is must be always disabled

Related issue/s

  • Configs ITISFoundation/private-issues#14

How to test

Dev-ops

These are the values of WEBSERVER_FUNCTION set for each deploy (@wvangeit will change these in the future according to their release workflow):

@pcrespov pcrespov self-assigned this May 26, 2025
@pcrespov pcrespov added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label May 26, 2025
@pcrespov pcrespov added this to the Bazinga! milestone May 26, 2025
@pcrespov pcrespov changed the title 🔨 Exposes WEBSERVER_FUNCTION env to wb-api-server simcore service 🔨 Exposes WEBSERVER_FUNCTION env to wb-api-server simcore service ⚠️ May 26, 2025
@pcrespov pcrespov marked this pull request as ready for review May 26, 2025 08:59
@pcrespov pcrespov requested a review from wvangeit May 26, 2025 09:00
@wvangeit wvangeit requested a review from JavierGOrdonnez May 26, 2025 09:01
Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @pcrespov

@pcrespov pcrespov enabled auto-merge (squash) May 26, 2025 12:02
@pcrespov
Copy link
Member Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented May 26, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images

@pcrespov pcrespov added the 🤖-automerge marks PR as ready to be merged for Mergify label May 26, 2025
@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.36%. Comparing base (403186c) to head (3dbd49e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7751      +/-   ##
==========================================
+ Coverage   87.05%   87.36%   +0.30%     
==========================================
  Files        1804     1834      +30     
  Lines       69314    71266    +1952     
  Branches     1214     1214              
==========================================
+ Hits        60341    62261    +1920     
- Misses       8630     8662      +32     
  Partials      343      343              
Flag Coverage Δ
integrationtests 64.37% <ø> (+0.02%) ⬆️
unittests 86.59% <ø> (+0.33%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.92% <ø> (ø)
pkg_dask_task_models_library 79.55% <ø> (ø)
pkg_models_library 93.08% <ø> (ø)
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.61% <ø> (ø)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library 71.86% <ø> (ø)
pkg_settings_library 90.90% <ø> (ø)
pkg_simcore_sdk 85.13% <ø> (+0.05%) ⬆️
agent 96.46% <ø> (ø)
api_server 91.79% <ø> (ø)
autoscaling 96.07% <ø> (∅)
catalog 92.29% <ø> (ø)
clusters_keeper 99.25% <ø> (ø)
dask_sidecar 91.67% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.87% <ø> (ø)
director_v2 91.04% <ø> (+0.02%) ⬆️
dynamic_scheduler 96.76% <ø> (ø)
dynamic_sidecar 90.19% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.63% <ø> (ø)
resource_usage_tracker 88.81% <ø> (-0.22%) ⬇️
storage 87.81% <ø> (+0.31%) ⬆️
webclient ∅ <ø> (∅)
webserver 85.69% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 403186c...3dbd49e. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov force-pushed the is14/functions-config branch from e04f212 to 8be9553 Compare May 26, 2025 13:08
@pcrespov pcrespov force-pushed the is14/functions-config branch from 8be9553 to 3dbd49e Compare May 26, 2025 13:09
@sonarqubecloud
Copy link

@pcrespov pcrespov merged commit 7ac9104 into ITISFoundation:master May 26, 2025
95 checks passed
@pcrespov pcrespov deleted the is14/functions-config branch May 26, 2025 14:23
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants