🎨 Maintenance: change default chunk size to compute checksums to 8MiB instead of 5KB #7753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7753 +/- ##
==========================================
- Coverage 86.78% 86.48% -0.31%
==========================================
Files 1841 1433 -408
Lines 71499 59874 -11625
Branches 1214 616 -598
==========================================
- Hits 62050 51780 -10270
+ Misses 9107 7894 -1213
+ Partials 342 200 -142
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
sanderegg
changed the title
sanderegg
force-pushed
the
bugfix/issue-with-upload
branch
from
22b638e to
51ad5bd
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR increases the default chunk size used for computing SHA256 checksums from 4KB to 8MiB to enhance performance when processing large files. It updates related test fixtures to use asynchronous factory functions and removes an unnecessary conversion in the checksum generation.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/simcore-sdk/tests/integration/test_node_ports_common_filemanager.py | Updated optional_sync_settings to use async factories for settings retrieval. |
| packages/simcore-sdk/tests/integration/conftest.py | Modified factory fixtures to return async factory functions and adjusted their invocations. |
| packages/simcore-sdk/src/simcore_sdk/node_ports_common/filemanager.py | Removed unnecessary SHA256Str conversion when generating file checksums. |
| packages/service-library/src/servicelib/file_utils.py | Increased default chunk_size from CHUNK_4KB to CHUNK_8MB and adjusted corresponding comments. |
GitHK
approved these changes
May 26, 2025
pcrespov
approved these changes
May 26, 2025
sanderegg
force-pushed
the
bugfix/issue-with-upload
branch
from
51ad5bd to
6a93cfa
Compare
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
sanderegg
force-pushed
the
bugfix/issue-with-upload
branch
from
6a93cfa to
6df8555
Compare
Member
Author
|
@mergify queue |
sanderegg
force-pushed
the
bugfix/issue-with-upload
branch
from
f96ea31 to
60704c6
Compare
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at da1e85f |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
chunk_sizein thecreate_sha256_checksumfunction fromCHUNK_4KBtoCHUNK_8MBto improve performance when processing large files. (packages/service-library/src/servicelib/file_utils.py, packages/service-library/src/servicelib/file_utils.pyL48-R51)Related issue/s
How to test
Dev-ops