-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 Fixes exclusive decorator to handle CouldNotAcquireLockError gracefully #7757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixes exclusive decorator to handle CouldNotAcquireLockError gracefully #7757
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7757 +/- ##
==========================================
- Coverage 87.35% 87.13% -0.22%
==========================================
Files 1841 1433 -408
Lines 71462 59838 -11624
Branches 1214 616 -598
==========================================
- Hits 62427 52142 -10285
+ Misses 8693 7497 -1196
+ Partials 342 199 -143
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes a bug by updating the exclusive_periodic decorator to gracefully handle CouldNotAcquireLockError.
- Added silence_exceptions decorator to suppress specific errors from replicas raising CouldNotAcquireLockError.
- Retains the original periodic and exclusive logic for background tasks.
|
@mergify queue |
🟠 Waiting for conditions to match
|
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, thanks



What do these changes do?
Suppresses
CouldNotAcquireLockErrorin the cases of background task in replicas are not getting a lock because one of the replicas own it. (which is as expected)!Related issue/s
How to test
Dev-ops