Skip to content

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented May 27, 2025

What do these changes do?

Avoids extra long error/debug messages when the director. This was caused because this error was not correctly handled in the web-server. This PR removes custom handler for DirectorServiceError and updates to error mapping to 503 that will auto generate a support ID for the front-end and log a detailed troubleshooting to analyze the issue.

Related issue/s

How to test

Dev-ops

@pcrespov pcrespov added this to the Bazinga! milestone May 27, 2025
@pcrespov pcrespov self-assigned this May 27, 2025
@pcrespov pcrespov added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label May 27, 2025
@codecov
Copy link

codecov bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 82.05128% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.50%. Comparing base (540f786) to head (fce494f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7761      +/-   ##
==========================================
- Coverage   86.72%   82.50%   -4.23%     
==========================================
  Files        1850      710    -1140     
  Lines       71777    33688   -38089     
  Branches     1215      176    -1039     
==========================================
- Hits        62252    27794   -34458     
+ Misses       9184     5836    -3348     
+ Partials      341       58     -283     
Flag Coverage Δ
integrationtests 64.27% <74.35%> (+0.05%) ⬆️
unittests 86.68% <64.10%> (+0.19%) ⬆️
Components Coverage Δ
api 76.84% <ø> (ø)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.90% <ø> (-8.20%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 77.64% <ø> (-13.45%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.34% <ø> (-1.74%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 83.71% <82.05%> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 540f786...fce494f. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov changed the title WIP: 🐛 Fixes long error/debug message in the front-end WIP: 🐛 Fixes extra long error/debug message in the front-end May 27, 2025
@pcrespov pcrespov changed the title WIP: 🐛 Fixes extra long error/debug message in the front-end 🐛 Fixes extra long error/debug message in the front-end May 27, 2025
@pcrespov pcrespov marked this pull request as ready for review May 27, 2025 11:42
@pcrespov pcrespov added the 🤖-automerge marks PR as ready to be merged for Mergify label May 27, 2025
@pcrespov pcrespov requested review from bisgaard-itis and Copilot May 27, 2025 11:43
@pcrespov pcrespov enabled auto-merge (squash) May 27, 2025 11:43
@pcrespov
Copy link
Member Author

@mergify queue

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue with extra long error/debug messages on the front-end by simplifying the error handling for DirectorServiceError. Key changes include:

  • Removing a custom exception handler for DirectorServiceError.
  • Updating the exception-to-HTTP error mapping to return a 503 status code with a concise error message that includes a support prompt.
  • Cleaning up unused imports related to the removed handler.

@mergify
Copy link
Contributor

mergify bot commented May 27, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@pcrespov pcrespov force-pushed the is7738/fix-directorv2-exception branch from bd75711 to 1a46510 Compare May 30, 2025 11:19
@pcrespov pcrespov disabled auto-merge May 30, 2025 15:40
@pcrespov pcrespov enabled auto-merge (squash) May 30, 2025 15:40
@pcrespov pcrespov disabled auto-merge May 30, 2025 15:41
@pcrespov pcrespov merged commit f98c431 into ITISFoundation:master May 30, 2025
3 of 4 checks passed
@pcrespov pcrespov deleted the is7738/fix-directorv2-exception branch May 30, 2025 15:41
@sonarqubecloud
Copy link

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

An error in the director-v2 is sent as is to the frontend with the full traceback

4 participants