-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 Fixes extra long error/debug message in the front-end #7761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fixes extra long error/debug message in the front-end #7761
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7761 +/- ##
==========================================
- Coverage 86.72% 82.50% -4.23%
==========================================
Files 1850 710 -1140
Lines 71777 33688 -38089
Branches 1215 176 -1039
==========================================
- Hits 62252 27794 -34458
+ Misses 9184 5836 -3348
+ Partials 341 58 -283
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@mergify queue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue with extra long error/debug messages on the front-end by simplifying the error handling for DirectorServiceError. Key changes include:
- Removing a custom exception handler for DirectorServiceError.
- Updating the exception-to-HTTP error mapping to return a 503 status code with a concise error message that includes a support prompt.
- Cleaning up unused imports related to the removed handler.
services/web/server/src/simcore_service_webserver/director_v2/_controller/_rest_exceptions.py
Outdated
Show resolved
Hide resolved
🟠 Waiting for conditions to match
|
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
services/web/server/src/simcore_service_webserver/director_v2/_controller/_rest_exceptions.py
Outdated
Show resolved
Hide resolved
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
bd75711 to
1a46510
Compare
…rror and improve error context creation
|



What do these changes do?
Avoids extra long error/debug messages when the director. This was caused because this error was not correctly handled in the web-server. This PR removes custom handler for
DirectorServiceErrorand updates to error mapping to 503 that will auto generate asupport IDfor the front-end and log a detailed troubleshooting to analyze the issue.Related issue/s
supportIDmust always be shown in the error dialog #7762How to test
Dev-ops