-
Notifications
You must be signed in to change notification settings - Fork 32
⬆️♻️Uniformize uvicorn/fastapi dependencies repository-wide #7765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️♻️Uniformize uvicorn/fastapi dependencies repository-wide #7765
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7765 +/- ##
==========================================
- Coverage 86.79% 86.59% -0.21%
==========================================
Files 1841 1451 -390
Lines 71507 60703 -10804
Branches 1215 664 -551
==========================================
- Hits 62067 52564 -9503
+ Misses 9098 7931 -1167
+ Partials 342 208 -134
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@mergify queue |
🟠 Waiting for conditions to match
|
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
greatly appreciated
3d109b6 to
962ebd0
Compare
|



What do these changes do?
Some services were installing just
fastapiothersfastapi[all]othersfastapi[standard].The recommended approach is to install
fastapi[standard]which ensuresuvicorn[standard]is also installed together withuvloopfor best performance.in particular:
were missing uvloop.
Also this generalizes the installation of
httpx[http2]instead ofhttpxbringing the option to have a client with http/2 protocol support.In general I think our layered dependency system is ok, with some pros/cons:
_base.insince they are already pre-installed by the dependenciesHighlights on updated libraries (only updated libraries are included)
api-server⬆️🧪
aws-library🧪
catalog⬆️
datcore-adapter⬆️
director⬆️
docker-api-proxy🧪
dynamic-scheduler⬆️
dynamic-sidecar⬆️
efs-guardian⬆️
helpers🧪
invitations⬆️
payments⬆️
resource-usage-tracker⬆️
service-library🧪
storage⬆️
resource-usage-tracker⬆️
catalog⬆️
director-v2⬆️
director⬆️
storage⬆️
director⬆️
efs-guardian🧪
payments⬆️
resource-usage-tracker🧪
director⬆️
payments⬆️
catalog⬆️
director-v2⬆️
director⬆️
storage⬆️
api-server⬆️🧪
catalog⬆️
datcore-adapter⬆️
director⬆️
dynamic-scheduler⬆️
dynamic-sidecar⬆️
efs-guardian⬆️
invitations⬆️
notifications⬆️
payments⬆️
resource-usage-tracker⬆️
service-library🧪
storage⬆️
web🧪
resource-usage-tracker⬆️
Legend:
Related issue/s
How to test
Dev-ops