Skip to content

Conversation

@wvangeit
Copy link
Contributor

What do these changes do?

Make sure the function service calls are using product_name for access rights/filtering/ etc

How to test

There is a test in the unit tests.
Create a function / function job / function job collection in a certain product, try to access it in other product.

Dev-ops

No env changes

@wvangeit wvangeit added this to the Bazinga! milestone May 30, 2025
@wvangeit wvangeit self-assigned this May 30, 2025
@wvangeit wvangeit added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs a:api framework api, data schemas, a:database associated to postgres service and postgres-database package a:apiserver api-server service πŸ€–-automerge marks PR as ready to be merged for Mergify labels May 30, 2025
@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.73%. Comparing base (39f1b4f) to head (d818e50).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7771      +/-   ##
==========================================
- Coverage   86.73%   86.73%   -0.01%     
==========================================
  Files        1850     1758      -92     
  Lines       71793    69281    -2512     
  Branches     1215     1061     -154     
==========================================
- Hits        62271    60088    -2183     
+ Misses       9181     8888     -293     
+ Partials      341      305      -36     
Flag Coverage Ξ”
integrationtests 64.22% <100.00%> (+0.02%) ⬆️
unittests 86.46% <95.00%> (-0.03%) ⬇️
Components Coverage Ξ”
api βˆ… <ΓΈ> (βˆ…)
pkg_aws_library βˆ… <ΓΈ> (βˆ…)
pkg_dask_task_models_library βˆ… <ΓΈ> (βˆ…)
pkg_models_library 93.14% <100.00%> (+<0.01%) ⬆️
pkg_notifications_library 85.26% <ΓΈ> (ΓΈ)
pkg_postgres_database 88.16% <ΓΈ> (ΓΈ)
pkg_service_integration 69.92% <ΓΈ> (ΓΈ)
pkg_service_library 71.86% <0.00%> (+<0.01%) ⬆️
pkg_settings_library βˆ… <ΓΈ> (βˆ…)
pkg_simcore_sdk 85.09% <ΓΈ> (ΓΈ)
agent 96.29% <ΓΈ> (ΓΈ)
api_server 91.78% <100.00%> (+<0.01%) ⬆️
autoscaling 96.03% <ΓΈ> (ΓΈ)
catalog 92.25% <ΓΈ> (ΓΈ)
clusters_keeper 99.13% <ΓΈ> (ΓΈ)
dask_sidecar 91.67% <ΓΈ> (ΓΈ)
datcore_adapter 97.94% <ΓΈ> (ΓΈ)
director 76.73% <ΓΈ> (ΓΈ)
director_v2 91.02% <ΓΈ> (ΓΈ)
dynamic_scheduler 96.69% <ΓΈ> (ΓΈ)
dynamic_sidecar 90.08% <ΓΈ> (ΓΈ)
efs_guardian 89.65% <ΓΈ> (ΓΈ)
invitations 93.00% <ΓΈ> (ΓΈ)
payments 92.57% <ΓΈ> (ΓΈ)
resource_usage_tracker 88.98% <ΓΈ> (ΓΈ)
storage 87.53% <ΓΈ> (-0.11%) ⬇️
webclient βˆ… <ΓΈ> (βˆ…)
webserver 83.72% <100.00%> (-0.04%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 39f1b4f...d818e50. Read the comment docs.

πŸš€ New features to boost your workflow:
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wvangeit
Copy link
Contributor Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented May 30, 2025

queue

βœ… The pull request has been merged automatically

The pull request has been merged automatically at 30b1302

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@sonarqubecloud
Copy link

@mergify mergify bot merged commit 30b1302 into ITISFoundation:master May 30, 2025
96 checks passed
@wvangeit wvangeit deleted the add_product_to_functions branch May 30, 2025 18:06
@mrnicegyu11
Copy link
Member

For the record this merge as-is triggered an alembic DB migration error at least on osparc-master.speag.com

sqlalchemy.exc.IntegrityError: (psycopg2.errors.NotNullViolation) column "product_name" of relation "funcapi_function_job_collections_access_rights" contains null values
[SQL: ALTER TABLE funcapi_function_job_collections_access_rights ADD COLUMN product_name VARCHAR NOT NULL]

@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

πŸ€–-automerge marks PR as ready to be merged for Mergify a:api framework api, data schemas, a:apiserver api-server service a:database associated to postgres service and postgres-database package a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants