-
Notifications
You must be signed in to change notification settings - Fork 32
Add product permissions to functions π¨ ποΈ #7771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add product permissions to functions π¨ ποΈ #7771
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7771 +/- ##
==========================================
- Coverage 86.73% 86.73% -0.01%
==========================================
Files 1850 1758 -92
Lines 71793 69281 -2512
Branches 1215 1061 -154
==========================================
- Hits 62271 60088 -2183
+ Misses 9181 8888 -293
+ Partials 341 305 -36
Continue to review full report in Codecov by Sentry.
π New features to boost your workflow:
|
|
@mergify queue |
β The pull request has been merged automaticallyThe pull request has been merged automatically at 30b1302 |
pcrespov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx
|
|
For the record this merge as-is triggered an alembic DB migration error at least on osparc-master.speag.com |



What do these changes do?
Make sure the function service calls are using product_name for access rights/filtering/ etc
How to test
There is a test in the unit tests.
Create a function / function job / function job collection in a certain product, try to access it in other product.
Dev-ops
No env changes