Function cache check success 🎨 #7789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wvangeit
requested review from
GitHK,
matusdrobuliak66,
pcrespov and
sanderegg
as code owners
wvangeit
added
a:webserver
Contributor
Author
|
@mergify queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 15efb0b |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7789 +/- ##
==========================================
- Coverage 86.73% 86.41% -0.32%
==========================================
Files 1850 1435 -415
Lines 71844 60118 -11726
Branches 1215 615 -600
==========================================
- Hits 62312 51952 -10360
+ Misses 9191 7968 -1223
+ Partials 341 198 -143
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
matusdrobuliak66
approved these changes
Jun 2, 2025
…parc-simcore into function_cache_check_success
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
When returning a cached function job, make sure the function job was successful. To accomplish this the find_cached functions now returns a list of function jobs.
Related issue/s
How to test
Run a function with the same arguments, check if function immediately returns results with the same project job id.
Dev-ops
No changes ENV