🎨🐛 [Frontend] Runs and Tasks sorting #7790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
changed the title
odeimaiz
changed the title
odeimaiz
changed the title
…rc-simcore into feature/pagination-buttons
Member
Author
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 8df1e20 |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enables server-side sorting for runs and subruns tables, adjusts credit handling for subjobs, and tightens template editing permissions.
- Extend
fetchSubJobsto accept anorderByparameter and propagate it through table models and API endpoints - Replace static sortable flags with
sortableMapin column definitions and overridesortByColumn - Invert
osparcCreditssign on subjobs and require write access plus tester permission for template type edits
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/store/Jobs.js | Added orderBy parameter to fetchSubJobs |
| services/static-webserver/client/source/class/osparc/jobs/SubRunsTableModel.js | Introduced orderBy property and override of sortByColumn |
| services/static-webserver/client/source/class/osparc/jobs/SubRunsTable.js | Added sortableMap for the Started column |
| services/static-webserver/client/source/class/osparc/jobs/RunsTableModel.js | Switched to sortableMap usage and added sortByColumn override |
| services/static-webserver/client/source/class/osparc/jobs/RunsTable.js | Replaced sortable flags with sortableMap in column config |
| services/static-webserver/client/source/class/osparc/info/StudyLarge.js | Updated template edit check to require write permission |
| services/static-webserver/client/source/class/osparc/data/SubJob.js | Inverted osparcCredits sign when parsing |
| services/static-webserver/client/source/class/osparc/data/Resources.js | Parameterized order_by in API endpoint URLs |
Comments suppressed due to low confidence (2)
services/static-webserver/client/source/class/osparc/jobs/SubRunsTable.js:93
- [nitpick] If sorting by the 'Ended' timestamp should be supported, add a
sortableMap: "ended_at"to the END column definition.
width: 130,
services/static-webserver/client/source/class/osparc/jobs/RunsTable.js:95
- [nitpick] The Project column no longer has a
sortableMap; if sorting by project name is needed, consider adding asortableMapproperty.
width: 150,
services/static-webserver/client/source/class/osparc/jobs/SubRunsTableModel.js
Show resolved
Hide resolved
|
sanderegg
approved these changes
Jun 2, 2025
matusdrobuliak66
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue/s
How to test
Dev-ops