-
Notifications
You must be signed in to change notification settings - Fork 32
🎨 Set 1 minute timeout as default in httpx clients used in api-server #7791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Set 1 minute timeout as default in httpx clients used in api-server #7791
Conversation
wvangeit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds ok for me, thanks.
Agreed about the long running tasks.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7791 +/- ##
===========================================
- Coverage 86.71% 67.76% -18.95%
===========================================
Files 1850 806 -1044
Lines 71842 37306 -34536
Branches 1215 176 -1039
===========================================
- Hits 62295 25281 -37014
- Misses 9206 11967 +2761
+ Partials 341 58 -283
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|



What do these changes do?
functions section api of the api-server. From there it is clear that the request made to the webserver for starting a computation sometimes exceeds the 5second default timeout.POST computations/{project_id}:startendpoint in the webserver and thePOST functions/{function_id}:runendpoint in the api-server should be converted into long running tasks, running in a celery worker. This is a quick fix meant to improve the situation before the release.Related issue/s
How to test
Dev-ops