Skip to content

Conversation

@bisgaard-itis
Copy link
Contributor

@bisgaard-itis bisgaard-itis commented Jun 2, 2025

What do these changes do?

  • Increase timeout in httpx client held by the api-server. This is motivated by the load tests I did for the new functions section api of the api-server. From there it is clear that the request made to the webserver for starting a computation sometimes exceeds the 5second default timeout.
  • I am fully aware this is not the correct fix. Rather, as discussed with @sanderegg , both the POST computations/{project_id}:start endpoint in the webserver and the POST functions/{function_id}:run endpoint in the api-server should be converted into long running tasks, running in a celery worker. This is a quick fix meant to improve the situation before the release.

Related issue/s

How to test

Dev-ops

@bisgaard-itis bisgaard-itis requested a review from pcrespov as a code owner June 2, 2025 12:29
@bisgaard-itis bisgaard-itis self-assigned this Jun 2, 2025
@bisgaard-itis bisgaard-itis added this to the Bazinga! milestone Jun 2, 2025
Copy link
Contributor

@wvangeit wvangeit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds ok for me, thanks.
Agreed about the long running tasks.

@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.76%. Comparing base (c07a2bf) to head (cef2552).
Report is 19 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (c07a2bf) and HEAD (cef2552). Click for more details.

HEAD has 31 uploads less than BASE
Flag BASE (c07a2bf) HEAD (cef2552)
unittests 32 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7791       +/-   ##
===========================================
- Coverage   86.71%   67.76%   -18.95%     
===========================================
  Files        1850      806     -1044     
  Lines       71842    37306    -34536     
  Branches     1215      176     -1039     
===========================================
- Hits        62295    25281    -37014     
- Misses       9206    11967     +2761     
+ Partials      341       58      -283     
Flag Coverage Δ
integrationtests 64.24% <ø> (+0.04%) ⬆️
unittests 91.79% <100.00%> (+5.32%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.95% <ø> (-8.08%) ⬇️
agent ∅ <ø> (∅)
api_server 91.79% <100.00%> (+<0.01%) ⬆️
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 77.73% <ø> (-13.34%) ⬇️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.34% <ø> (-1.74%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 56.39% <ø> (-27.31%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c07a2bf...cef2552. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bisgaard-itis bisgaard-itis enabled auto-merge (squash) June 2, 2025 12:55
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2025

@sanderegg sanderegg disabled auto-merge June 2, 2025 13:33
@sanderegg sanderegg merged commit 5d519af into ITISFoundation:master Jun 2, 2025
92 of 95 checks passed
@bisgaard-itis bisgaard-itis deleted the increase-webserver-client-timeout branch June 2, 2025 13:33
@bisgaard-itis bisgaard-itis added the release Preparation for pre-release/release label Jun 5, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Jun 6, 2025
92 tasks
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:apiserver api-server service Meta-modeling release Preparation for pre-release/release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants