Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Jun 3, 2025

What do these changes do?

  • 🐛 fix wrong project name in billing center usage view for computational services (before there was "undefined-metadata")
  • reported by @capbrown

Related issue/s

How to test

Dev-ops

@matusdrobuliak66 matusdrobuliak66 changed the title 🐛 fix project name substitution 🐛 fix project name in billing Jun 3, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review June 3, 2025 13:32
@matusdrobuliak66 matusdrobuliak66 self-assigned this Jun 3, 2025
@matusdrobuliak66 matusdrobuliak66 added the a:director-v2 issue related with the director-v2 service label Jun 3, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Bazinga! milestone Jun 3, 2025
@matusdrobuliak66 matusdrobuliak66 changed the title 🐛 fix project name in billing 🐛 fix wrong project name in billing center usage view Jun 3, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 3, 2025

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@codecov
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.90%. Comparing base (15efb0b) to head (7404ab7).
Report is 17 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (15efb0b) and HEAD (7404ab7). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (15efb0b) HEAD (7404ab7)
unittests 31 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #7798       +/-   ##
===========================================
- Coverage   86.67%   67.90%   -18.78%     
===========================================
  Files        1802      703     -1099     
  Lines       69983    33545    -36438     
  Branches     1215      176     -1039     
===========================================
- Hits        60659    22778    -37881     
- Misses       8983    10709     +1726     
+ Partials      341       58      -283     
Flag Coverage Δ
integrationtests 64.19% <ø> (ø)
unittests 84.44% <ø> (-1.98%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 76.95% <ø> (-8.14%) ⬇️
agent ∅ <ø> (∅)
api_server ∅ <ø> (∅)
autoscaling ∅ <ø> (∅)
catalog ∅ <ø> (∅)
clusters_keeper ∅ <ø> (∅)
dask_sidecar ∅ <ø> (∅)
datcore_adapter ∅ <ø> (∅)
director ∅ <ø> (∅)
director_v2 91.13% <ø> (+0.02%) ⬆️
dynamic_scheduler ∅ <ø> (∅)
dynamic_sidecar 88.34% <ø> (-1.74%) ⬇️
efs_guardian ∅ <ø> (∅)
invitations ∅ <ø> (∅)
payments ∅ <ø> (∅)
resource_usage_tracker ∅ <ø> (∅)
storage ∅ <ø> (∅)
webclient ∅ <ø> (∅)
webserver 56.38% <ø> (-27.37%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15efb0b...7404ab7. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matusdrobuliak66 matusdrobuliak66 merged commit 7d720d1 into ITISFoundation:master Jun 3, 2025
93 of 95 checks passed
@matusdrobuliak66 matusdrobuliak66 deleted the fix-project-name-listing branch June 3, 2025 14:02
@matusdrobuliak66 matusdrobuliak66 added the release Preparation for pre-release/release label Jun 5, 2025
bisgaard-itis added a commit to giancarloromeo/osparc-simcore that referenced this pull request Jun 5, 2025
bisgaard-itis added a commit to giancarloromeo/osparc-simcore that referenced this pull request Jun 5, 2025
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:director-v2 issue related with the director-v2 service release Preparation for pre-release/release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants