-
Notifications
You must be signed in to change notification settings - Fork 32
🐛 use httpx to download output ports
#7824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 use httpx to download output ports
#7824
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7824 +/- ##
==========================================
+ Coverage 86.74% 88.11% +1.36%
==========================================
Files 1850 1257 -593
Lines 71934 53961 -17973
Branches 1218 176 -1042
==========================================
- Hits 62399 47547 -14852
+ Misses 9193 6356 -2837
+ Partials 342 58 -284
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
httpx to download output ports
matusdrobuliak66
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 2f0a89d |
sanderegg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments
| response = await stack.enter_async_context(session.get(url)) | ||
| if response.status == status.HTTP_404_NOT_FOUND: | ||
| client = await stack.enter_async_context( | ||
| httpx.AsyncClient( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
creating a new client everytime is costly and wasting resources.
here you are changing the behavior. I don't want to stop this now, but please take care of that in a next PR, thank you.
Create an issue and let's fix this calmly.



What do these changes do?
Inside nodeports, used only by the dynamic-sidecar, the port download was not behaving as expected.
Replaced aiohttp client with httpx which addresses #7821 that was reported on AWS master.
The issue was very hard to reduce and could only be tested agains AWS master deployment. Also in a certain setup it appeared 100% of cases. In other setups it took a few tries before it manifested.
Related issue/s
How to test
Dev-ops