🐛 [Frontend] Incomplete node data in the backend #7864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
odeimaiz
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where node data was incomplete in the backend by ensuring that the correct source objects are used when calculating and applying diffs across studies and workbenches.
- Refactored __getStudyDiffs to use a consolidated object (studyDiffs) for both the source study and its diffs.
- Updated patchWorkbenchDelayed to accept and use workbenchSource for node data.
- Renamed parameters in patchStudyDelayed for consistency, passing studySource to the workbench patch.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js | Refactored the diff generation to return a unified studyDiffs object. |
| services/static-webserver/client/source/class/osparc/data/model/Workbench.js | Updated patchWorkbenchDelayed to use workbenchSource instead of node.serialize(). |
| services/static-webserver/client/source/class/osparc/data/model/Study.js | Renamed parameter and updated calls to use studySource consistently. |
Comments suppressed due to low confidence (2)
services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js:861
- [nitpick] Consider computing the diff value before constructing the studyDiffs object so that you can build and return the object in a single step, reducing the re-assignment of properties.
const studyDiffs = { sourceStudy, delta: {} }
services/static-webserver/client/source/class/osparc/data/model/Study.js:699
- Verify that the renaming from sourceStudy to studySource is consistently applied in both the function signature and the documentation to prevent any confusion.
/* updated doc comment with studySource */
services/static-webserver/client/source/class/osparc/data/model/Workbench.js
Show resolved
Hide resolved
odeimaiz
requested review from
GitHK,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
|
matusdrobuliak66
approved these changes
Jun 10, 2025
Member
Author
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 8d96382 |
GitHK
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
reported by @sanderegg , thanks!
Similar issue as in #7828, but this time in the node level
Related issue/s
How to test
Dev-ops