🎨 [Frontend] Enh: Better fit loading page #7866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
requested review from
GitHK,
Copilot,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
sanderegg
approved these changes
Jun 10, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the loading page layout for better small‐screen fitting and constrains the progress sequence width.
- Replaced the grid layout in
Loading.jswith a vertical box (VBox) and updated widget insertion. - Added flexible spacers and switched toolbar visibility to “excluded” state.
- Set a 400px
maxWidthon the main loading page inNodeProgressSequence.js.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/ui/message/Loading.js | Switched from Grid to VBox layout and updated _addAt calls |
| services/static-webserver/client/source/class/osparc/data/model/NodeProgressSequence.js | Added maxWidth: 400 to main loading page composite |
services/static-webserver/client/source/class/osparc/ui/message/Loading.js
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/ui/message/Loading.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/ui/message/Loading.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/ui/message/Loading.js
Outdated
Show resolved
Hide resolved
services/static-webserver/client/source/class/osparc/data/model/NodeProgressSequence.js
Show resolved
Hide resolved
Member
Author
|
@Mergifyio queue |
Contributor
🟠 Waiting for conditions to match
|
giancarloromeo
approved these changes
Jun 10, 2025
odeimaiz
added
🤖-automerge
Member
Author
|
@Mergifyio queue |
Contributor
🛑 The pull request has been removed from the queue
|
|
matusdrobuliak66
removed
the
🤖-automerge
matusdrobuliak66
approved these changes
Jun 10, 2025
Contributor
|
This pull request has been removed from the queue for the following reason: Pull request #7866 has been dequeued. The pull request rule doesn't match anymore. You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
Collaborator
|
@Mergifyio queue |
Contributor
🟠 Waiting for conditions to match
|
This was referenced Jun 17, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
In small screens the loading page might get cropped, this PR changes its layout to improve the fitting.
Before:
After:
Related issue/s
How to test
Dev-ops