🐛 [Frontend] Fix: show support id when pipeline fails to start #7874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
bug
odeimaiz
requested review from
GitHK,
Copilot,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refines the error logging behavior on the frontend when starting a pipeline fails, ensuring that a support ID is displayed to aid in debugging. Key updates include:
- Unifying error logging in StudyEditor.js by replacing conditional branches with a single logError call.
- Refactoring FlashMessenger.js to improve clarity by extracting the current study before assembling clipboard data.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js | Replaces conditional logging for error status "402" with a unified error logging approach using logError. |
| services/static-webserver/client/source/class/osparc/FlashMessenger.js | Introduces a local currentStudy variable to retrieve study UUID, making the clipboard data assembly more explicit. |
Comments suppressed due to low confidence (2)
services/static-webserver/client/source/class/osparc/desktop/StudyEditor.js:622
- The change to unified error logging simplifies the logic, but please verify that removing the explicit handling for error status '402' does not affect any specialized behavior expected for payment-related errors.
osparc.FlashMessenger.logError(err);
services/static-webserver/client/source/class/osparc/FlashMessenger.js:115
- [nitpick] The refactoring to use the currentStudy variable improves clarity; however, please confirm that using currentStudy.getUuid() uniformly returns the correct and expected UUID format across all usage scenarios.
studyId: currentStudy ? currentStudy.getUuid() : "",
matusdrobuliak66
approved these changes
Jun 11, 2025
|
This was referenced Jun 17, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue/s
supportIDmust always be shown in the error dialog #7762How to test
Dev-ops