♻️ remove listing user services call from listing project #7881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matusdrobuliak66
requested review from
GitHK,
pcrespov and
sanderegg
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7881 +/- ##
==========================================
- Coverage 85.41% 84.97% -0.44%
==========================================
Files 1375 688 -687
Lines 54796 32594 -22202
Branches 652 176 -476
==========================================
- Hits 46804 27697 -19107
+ Misses 7798 4839 -2959
+ Partials 194 58 -136
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Member
|
please review also |
pcrespov
added
the
a:webserver
pcrespov
approved these changes
Jun 12, 2025
sanderegg
reviewed
Jun 12, 2025
Member
sanderegg
left a comment
sanderegg
left a comment
There was a problem hiding this comment.
I understand this will be clearly faster, but how is then that feature handled?
services/web/server/src/simcore_service_webserver/projects/_controller/projects_rest.py
Show resolved
Hide resolved
sanderegg
approved these changes
Jun 12, 2025
GitHK
approved these changes
Jun 12, 2025
|
matusdrobuliak66
merged commit b04091c
into
ITISFoundation:master
93 of 95 checks passed
This was referenced Jun 17, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The frontend is already handling service access rights. I think listing projects should be based purely on access rights to the project resources. This will significantly improve the initial listing, because retrieving all user services takes some time (although it's cached for one minute), but it's not necessary when listing projects.
_execute_without_permission_check--> theproject_to_produceA None check is also unnecessary, as this is already handled in the SQL query—we don’t list projects that don't belong to a product.Related issue/s
How to test
Dev-ops