Skip to content

Conversation

@matusdrobuliak66
Copy link
Collaborator

@matusdrobuliak66 matusdrobuliak66 commented Jun 12, 2025

What do these changes do?

  • ♻️ Maintenance: In the first step decouple listing projects repository and service layer. Repository returns ProjectListAtDB model and service returns ProjectDict model.

Related issue/s

How to test

🚨 test project listing manually in master

Dev-ops

@matusdrobuliak66 matusdrobuliak66 self-assigned this Jun 12, 2025
@matusdrobuliak66 matusdrobuliak66 added a:webserver webserver's codebase. Assigning the area is particularly useful for bugs t:maintenance Some planned maintenance work labels Jun 12, 2025
@matusdrobuliak66 matusdrobuliak66 added this to the Engage milestone Jun 12, 2025
@matusdrobuliak66 matusdrobuliak66 marked this pull request as ready for review June 12, 2025 15:17
@codecov
Copy link

codecov bot commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 95.58824% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.68%. Comparing base (a5afe8d) to head (57d1029).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7889      +/-   ##
==========================================
+ Coverage   88.00%   89.68%   +1.67%     
==========================================
  Files        1845     1454     -391     
  Lines       71182    60175   -11007     
  Branches     1220      476     -744     
==========================================
- Hits        62645    53966    -8679     
+ Misses       8185     6088    -2097     
+ Partials      352      121     -231     
Flag Coverage Δ
integrationtests 64.24% <31.81%> (-0.04%) ⬇️
unittests 88.02% <95.58%> (+1.42%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library 93.27% <100.00%> (+0.02%) ⬆️
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library ∅ <ø> (∅)
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.05% <ø> (ø)
agent 96.29% <ø> (ø)
api_server 92.31% <ø> (ø)
autoscaling 96.03% <ø> (ø)
catalog 92.29% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.57% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.73% <ø> (ø)
director_v2 91.08% <ø> (-0.02%) ⬇️
dynamic_scheduler 96.69% <ø> (ø)
dynamic_sidecar 90.09% <ø> (ø)
efs_guardian 89.65% <ø> (ø)
invitations 93.00% <ø> (ø)
payments 92.57% <ø> (ø)
resource_usage_tracker 89.11% <ø> (+0.10%) ⬆️
storage 87.46% <ø> (-0.15%) ⬇️
webclient ∅ <ø> (∅)
webserver 87.63% <93.18%> (+0.02%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5afe8d...57d1029. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@matusdrobuliak66 matusdrobuliak66 enabled auto-merge (squash) June 18, 2025 11:08
@matusdrobuliak66
Copy link
Collaborator Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Jun 18, 2025

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • label=🤖-automerge
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = system-tests
        • check-neutral = system-tests
        • check-skipped = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = unit-tests
        • check-neutral = unit-tests
        • check-skipped = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@matusdrobuliak66 matusdrobuliak66 changed the title ♻️ Maintenance/remove legacy db listing code ♻️ Maintenance/remove legacy db listing code 🚨🚨 Jun 18, 2025
@sonarqubecloud
Copy link

@matusdrobuliak66 matusdrobuliak66 merged commit f6efa8e into ITISFoundation:master Jun 18, 2025
93 of 95 checks passed
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request Aug 5, 2025
88 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a:webserver webserver's codebase. Assigning the area is particularly useful for bugs t:maintenance Some planned maintenance work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants