🎨 [Frontend] Enh: Visible input ports #7891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
odeimaiz
requested review from
GitHK,
Copilot,
giancarloromeo,
matusdrobuliak66,
pcrespov,
sanderegg and
wvangeit
odeimaiz
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
Enhance the dynamic input port visibility to support any port type and extend resource details controls (e.g., billing, open, preview) to work for both study and template resource types.
- PropForm: generalized the “hideable ports” logic from data-only to any type and renamed helper methods/variables for clarity.
- ResourceDetails: replaced repeated
resourceType === "study"checks with["study","template"].includes(...)and unified page enablement logic.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/form/renderer/PropForm.js | Generalized hideable-input detection to all port types and renamed methods/vars. |
| services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js | Added template support to resourceType checks; simplified page enablement calls. |
Comments suppressed due to low confidence (2)
services/static-webserver/client/source/class/osparc/form/renderer/PropForm.js:168
- [nitpick] The method name
__getVisibleEmptyLastPortis a bit ambiguous; consider renaming it to__getLastVisibleHideablePortto clearly pair with__getHideablePorts.
__getVisibleEmptyLastPort: function() {
services/static-webserver/client/source/class/osparc/dashboard/ResourceDetails.js:508
- You’ve removed the
resourceType === "study"guard, so this now runs for all resource types; verify thatcanShowPreviewhandles templates/services correctly or reintroduce a check to avoid enabling the preview page where it’s unsupported.
const enabled = osparc.study.Utils.canShowPreview(studyData);
Member
Author
|
@Mergifyio queue |
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 1b1b2a6 |
GitHK
approved these changes
Jun 13, 2025
pcrespov
approved these changes
Jun 13, 2025
|
This was referenced Jun 17, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Only
datatype ports were hideable in the node input ports view, this PR enhances this feature by supporting any type.Bonus:
Related issue/s
How to test
Dev-ops