🐛Increase node testing timeout to wait for website since Github machines are very weak #7893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
e2e
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR increases the waiting timeout in the end-to-end startup test to accommodate slower performance on GitHub's machines.
- Increases the timeout from 10 seconds to 60 seconds.
Comments suppressed due to low confidence (1)
tests/e2e/tests/startupCalls.js:50
- [nitpick] Consider adding a brief comment explaining why the timeout was increased to 60000ms (e.g., to accommodate GitHub machine performance).
await page.waitFor(60000);
Member
Author
|
@mergify queue |
sanderegg
force-pushed
the
increase-e2e-timeout
branch
from
d51539a to
2d9027f
Compare
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at d0e305f |
|
Member
|
Thanks for the effort 👍 Since I see that somehow the playwright test is more reliable, I might move this test there and remove this one. |
GitHK
approved these changes
Jun 13, 2025
pcrespov
approved these changes
Jun 13, 2025
This was referenced Jun 17, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Increased the time waiting for the website to come up. Since it is slow and the machines testing are weak.
now waits 1 minute instead of 10 seconds, which already on my own computer would not be enough.
These tests are impossible to test locally for me. I am tempted to move all this to playwright. or ditch them if it has no value.
Related issue/s
How to test
Dev-ops